Markduckworth/ppl
Hey there! So you want to contribute to a Firebase SDK? Before you file this pull request, please read these guidelines:
Discussion
- Read the contribution guidelines (CONTRIBUTING.md).
- If this has been discussed in an issue, make sure to link to the issue here. If not, go file an issue about this before creating a pull request to discuss.
Testing
- Make sure all existing tests in the repository pass after your change.
- If you fixed a bug or added a feature, add a new test to cover your code.
API Changes
- At this time we cannot accept changes that affect the public API. If you'd like to help us make Firebase APIs better, please propose your change in an issue so that we can discuss it together.
⚠️ No Changeset found
Latest commit: fd20eff30092a65cab35dae32f73c0057601af11
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Size Report 1
Affected Products
@firebase/firestoreType Base (caf3090) Merge (f880a0a) Diff browser 381 kB 414 kB +32.6 kB (+8.5%) main 588 kB 644 kB +55.7 kB (+9.5%) module 381 kB 414 kB +32.6 kB (+8.5%) react-native 382 kB 414 kB +32.6 kB (+8.5%) @firebase/firestore-liteType Base (caf3090) Merge (f880a0a) Diff browser 111 kB 143 kB +31.9 kB (+28.7%) main 153 kB 204 kB +51.5 kB (+33.7%) module 111 kB 143 kB +31.9 kB (+28.7%) react-native 111 kB 143 kB +31.9 kB (+28.7%) bundle16 size changes
Type Base (caf3090) Merge (f880a0a) Diff firestore (CSI Auto Indexing Disable and Delete) 272 kB 302 kB +30.0 kB (+11.0%) firestore (CSI Auto Indexing Enable) 272 kB 302 kB +30.0 kB (+11.0%) firestore (Persistence) 303 kB 333 kB +29.8 kB (+9.8%) firestore (Pipeline Query with lt filter) ? 146 kB ? (?) firestore (Query Cursors) 249 kB 269 kB +20.3 kB (+8.2%) firestore (Query) 247 kB 267 kB +20.3 kB (+8.2%) firestore (Read data once) 234 kB 259 kB +24.7 kB (+10.5%) firestore (Read Write w Persistence) 328 kB 348 kB +20.2 kB (+6.2%) firestore (Realtime updates) 237 kB 261 kB +24.7 kB (+10.4%) firestore (Transaction) 214 kB 234 kB +20.2 kB (+9.4%) firestore (Write data) 213 kB 236 kB +22.6 kB (+10.6%) firestore-lite (Query Cursors) 91.4 kB 111 kB +19.8 kB (+21.6%) firestore-lite (Query) 87.6 kB 107 kB +19.8 kB (+22.6%) firestore-lite (Read data once) 63.0 kB 87.8 kB +24.7 kB (+39.2%) firestore-lite (Transaction) 88.3 kB 108 kB +19.7 kB (+22.3%) firestore-lite (Write data) 72.6 kB 95.5 kB +22.8 kB (+31.4%) firebaseType Base (caf3090) Merge (f880a0a) Diff firebase-compat.js 794 kB 814 kB +20.0 kB (+2.5%) firebase-firestore-compat.js 346 kB 366 kB +20.0 kB (+5.8%) firebase-firestore-lite.js 119 kB 151 kB +31.8 kB (+26.8%) firebase-firestore.js 440 kB 473 kB +32.5 kB (+7.4%)
Test Logs