firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard

[DO NOT SUBMIT]Expose INVALID_LOGIN_CREDENTIALS as auth/invalid-login-credentials error.

Open prameshj opened this issue 2 years ago • 5 comments

This PR has the following changes:

  • Expose INVALID_LOGIN_CREDENTIALS as auth/invalid-login-credentials error.
  • Update the doc snippets for various SDK methods to explain the behavior when Email Enumeration Protection is enabled.
  • Mark fetchSignInMethodsForEmail and updateEmail as deprecated.

prameshj avatar Oct 26 '23 23:10 prameshj

🦋 Changeset detected

Latest commit: 293da7fec4270ead3135d897b4f8c849e7712090

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 26 '23 23:10 changeset-bot[bot]

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (a89e05b)Merge (62a8fa0)Diff
    browser177 kB177 kB+193 B (+0.1%)
    cordova205 kB205 kB+199 B (+0.1%)
    esm5230 kB230 kB+199 B (+0.1%)
    main175 kB175 kB+199 B (+0.1%)
    module177 kB177 kB+193 B (+0.1%)
    react-native194 kB194 kB+199 B (+0.1%)
  • @firebase/auth/cordova

    TypeBase (a89e05b)Merge (62a8fa0)Diff
    browser205 kB205 kB+199 B (+0.1%)
    module205 kB205 kB+199 B (+0.1%)
  • @firebase/auth/internal

    TypeBase (a89e05b)Merge (62a8fa0)Diff
    browser187 kB188 kB+193 B (+0.1%)
    esm5244 kB244 kB+199 B (+0.1%)
    main211 kB211 kB+199 B (+0.1%)
    module187 kB188 kB+193 B (+0.1%)
  • bundle

    TypeBase (a89e05b)Merge (62a8fa0)Diff
    auth (Anonymous)73.5 kB73.6 kB+58 B (+0.1%)
    auth (EmailAndPassword)81.4 kB81.4 kB+58 B (+0.1%)
    auth (GoogleFBTwitterGitHubPopup)100 kB100 kB+58 B (+0.1%)
    auth (GooglePopup)97.4 kB97.4 kB+58 B (+0.1%)
    auth (GoogleRedirect)97.6 kB97.7 kB+58 B (+0.1%)
    auth (Phone)83.8 kB83.8 kB+58 B (+0.1%)
  • firebase

    TypeBase (a89e05b)Merge (62a8fa0)Diff
    firebase-auth-compat.js136 kB136 kB+128 B (+0.1%)
    firebase-auth-cordova.js174 kB174 kB+192 B (+0.1%)
    firebase-auth.js147 kB147 kB+187 B (+0.1%)
    firebase-compat.js778 kB778 kB+128 B (+0.0%)

Test Logs

google-oss-bot avatar Oct 27 '23 00:10 google-oss-bot

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • ActionCodeOperation

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.6 kB37.6 kB+58 B (+0.2%)
      size-with-ext-deps58.5 kB58.5 kB+58 B (+0.1%)
    • ActionCodeURL

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size38.4 kB38.5 kB+58 B (+0.2%)
      size-with-ext-deps59.6 kB59.6 kB+58 B (+0.1%)
    • AuthCredential

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.6 kB37.7 kB+58 B (+0.2%)
      size-with-ext-deps58.5 kB58.5 kB+58 B (+0.1%)
    • AuthErrorCodes

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size42.4 kB42.5 kB+117 B (+0.3%)
      size-with-ext-deps63.3 kB63.4 kB+117 B (+0.2%)
    • EmailAuthCredential

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size42.9 kB43.0 kB+58 B (+0.1%)
      size-with-ext-deps63.8 kB63.9 kB+58 B (+0.1%)
    • EmailAuthProvider

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size44.4 kB44.4 kB+58 B (+0.1%)
      size-with-ext-deps65.5 kB65.6 kB+58 B (+0.1%)
    • FacebookAuthProvider

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size42.4 kB42.5 kB+58 B (+0.1%)
      size-with-ext-deps63.3 kB63.3 kB+58 B (+0.1%)
    • FactorId

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.4 kB37.4 kB+58 B (+0.2%)
      size-with-ext-deps58.2 kB58.3 kB+58 B (+0.1%)
    • GithubAuthProvider

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size42.4 kB42.5 kB+58 B (+0.1%)
      size-with-ext-deps63.3 kB63.3 kB+58 B (+0.1%)
    • GoogleAuthProvider

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size42.4 kB42.5 kB+58 B (+0.1%)
      size-with-ext-deps63.3 kB63.3 kB+58 B (+0.1%)
    • OAuthCredential

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size39.5 kB39.6 kB+58 B (+0.1%)
      size-with-ext-deps60.4 kB60.4 kB+58 B (+0.1%)
    • OAuthProvider

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size43.3 kB43.4 kB+58 B (+0.1%)
      size-with-ext-deps64.2 kB64.3 kB+58 B (+0.1%)
    • OperationType

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.4 kB37.5 kB+58 B (+0.2%)
      size-with-ext-deps58.3 kB58.3 kB+58 B (+0.1%)
    • PhoneAuthCredential

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size39.5 kB39.5 kB+58 B (+0.1%)
      size-with-ext-deps60.4 kB60.4 kB+58 B (+0.1%)
    • PhoneAuthProvider

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size41.2 kB41.2 kB+58 B (+0.1%)
      size-with-ext-deps62.1 kB62.1 kB+58 B (+0.1%)
    • PhoneMultiFactorGenerator

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size38.2 kB38.3 kB+58 B (+0.2%)
      size-with-ext-deps59.1 kB59.1 kB+58 B (+0.1%)
    • ProviderId

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.5 kB37.5 kB+58 B (+0.2%)
      size-with-ext-deps58.3 kB58.4 kB+58 B (+0.1%)
    • RecaptchaVerifier

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size43.9 kB44.0 kB+58 B (+0.1%)
      size-with-ext-deps64.8 kB64.9 kB+58 B (+0.1%)
    • SAMLAuthProvider

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size43.7 kB43.7 kB+58 B (+0.1%)
      size-with-ext-deps64.6 kB64.6 kB+58 B (+0.1%)
    • SignInMethod

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.5 kB37.6 kB+58 B (+0.2%)
      size-with-ext-deps58.4 kB58.4 kB+58 B (+0.1%)
    • TotpMultiFactorGenerator

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size39.9 kB39.9 kB+58 B (+0.1%)
      size-with-ext-deps60.7 kB60.8 kB+58 B (+0.1%)
    • TotpSecret

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size38.3 kB38.4 kB+58 B (+0.2%)
      size-with-ext-deps59.2 kB59.3 kB+58 B (+0.1%)
    • TwitterAuthProvider

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size42.4 kB42.5 kB+58 B (+0.1%)
      size-with-ext-deps63.3 kB63.3 kB+58 B (+0.1%)
    • applyActionCode

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.5 kB37.5 kB+58 B (+0.2%)
      size-with-ext-deps58.3 kB58.4 kB+58 B (+0.1%)
    • beforeAuthStateChanged

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.4 kB37.5 kB+58 B (+0.2%)
      size-with-ext-deps58.3 kB58.3 kB+58 B (+0.1%)
    • browserLocalPersistence

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size40.8 kB40.8 kB+58 B (+0.1%)
      size-with-ext-deps61.7 kB61.8 kB+58 B (+0.1%)
    • browserPopupRedirectResolver

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size61.8 kB61.9 kB+58 B (+0.1%)
      size-with-ext-deps82.9 kB82.9 kB+58 B (+0.1%)
    • browserSessionPersistence

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size40.8 kB40.8 kB+58 B (+0.1%)
      size-with-ext-deps61.7 kB61.8 kB+58 B (+0.1%)
    • checkActionCode

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size38.6 kB38.6 kB+58 B (+0.2%)
      size-with-ext-deps59.5 kB59.5 kB+58 B (+0.1%)
    • confirmPasswordReset

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.7 kB37.7 kB+58 B (+0.2%)
      size-with-ext-deps58.6 kB58.6 kB+58 B (+0.1%)
    • connectAuthEmulator

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size39.1 kB39.1 kB+58 B (+0.1%)
      size-with-ext-deps60.0 kB60.0 kB+58 B (+0.1%)
    • createUserWithEmailAndPassword

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size42.1 kB42.1 kB+58 B (+0.1%)
      size-with-ext-deps63.0 kB63.0 kB+58 B (+0.1%)
    • debugErrorMap

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size49.6 kB49.7 kB+134 B (+0.3%)
      size-with-ext-deps70.4 kB70.6 kB+134 B (+0.2%)
    • deleteUser

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.4 kB37.4 kB+58 B (+0.2%)
      size-with-ext-deps58.3 kB58.3 kB+58 B (+0.1%)
    • fetchSignInMethodsForEmail

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.7 kB37.7 kB+58 B (+0.2%)
      size-with-ext-deps58.6 kB58.6 kB+58 B (+0.1%)
    • getAdditionalUserInfo

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size38.7 kB38.7 kB+58 B (+0.1%)
      size-with-ext-deps59.6 kB59.6 kB+58 B (+0.1%)
    • getAuth

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size71.9 kB71.9 kB+58 B (+0.1%)
      size-with-ext-deps99.4 kB99.5 kB+58 B (+0.1%)
    • getIdToken

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.4 kB37.4 kB+58 B (+0.2%)
      size-with-ext-deps58.3 kB58.3 kB+58 B (+0.1%)
    • getIdTokenResult

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.3 kB37.4 kB+58 B (+0.2%)
      size-with-ext-deps58.2 kB58.3 kB+58 B (+0.1%)
    • getMultiFactorResolver

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size40.3 kB40.3 kB+58 B (+0.1%)
      size-with-ext-deps61.1 kB61.2 kB+58 B (+0.1%)
    • getRedirectResult

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size44.9 kB44.9 kB+58 B (+0.1%)
      size-with-ext-deps65.8 kB65.8 kB+58 B (+0.1%)
    • inMemoryPersistence

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.3 kB37.4 kB+58 B (+0.2%)
      size-with-ext-deps58.2 kB58.3 kB+58 B (+0.1%)
    • indexedDBLocalPersistence

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size44.8 kB44.8 kB+58 B (+0.1%)
      size-with-ext-deps65.7 kB65.7 kB+58 B (+0.1%)
    • initializeAuth

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.6 kB37.7 kB+58 B (+0.2%)
      size-with-ext-deps59.0 kB59.0 kB+58 B (+0.1%)
    • initializeRecaptchaConfig

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size40.3 kB40.3 kB+58 B (+0.1%)
      size-with-ext-deps61.2 kB61.2 kB+58 B (+0.1%)
    • isSignInWithEmailLink

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size38.5 kB38.6 kB+58 B (+0.2%)
      size-with-ext-deps59.7 kB59.7 kB+58 B (+0.1%)
    • linkWithCredential

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size38.4 kB38.4 kB+58 B (+0.2%)
      size-with-ext-deps59.3 kB59.3 kB+58 B (+0.1%)
    • linkWithPhoneNumber

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size41.9 kB42.0 kB+58 B (+0.1%)
      size-with-ext-deps62.8 kB62.9 kB+58 B (+0.1%)
    • linkWithPopup

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size48.5 kB48.5 kB+58 B (+0.1%)
      size-with-ext-deps69.4 kB69.4 kB+58 B (+0.1%)
    • linkWithRedirect

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size43.7 kB43.8 kB+58 B (+0.1%)
      size-with-ext-deps64.6 kB64.6 kB+58 B (+0.1%)
    • multiFactor

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size39.6 kB39.6 kB+58 B (+0.1%)
      size-with-ext-deps60.4 kB60.5 kB+58 B (+0.1%)
    • onAuthStateChanged

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.4 kB37.5 kB+58 B (+0.2%)
      size-with-ext-deps58.3 kB58.3 kB+58 B (+0.1%)
    • onIdTokenChanged

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.4 kB37.5 kB+58 B (+0.2%)
      size-with-ext-deps58.3 kB58.3 kB+58 B (+0.1%)
    • parseActionCodeURL

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size38.5 kB38.5 kB+58 B (+0.2%)
      size-with-ext-deps59.6 kB59.7 kB+58 B (+0.1%)
    • prodErrorMap

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.3 kB37.4 kB+58 B (+0.2%)
      size-with-ext-deps58.2 kB58.3 kB+58 B (+0.1%)
    • reauthenticateWithCredential

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size38.9 kB39.0 kB+58 B (+0.1%)
      size-with-ext-deps59.8 kB59.9 kB+58 B (+0.1%)
    • reauthenticateWithPhoneNumber

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size42.5 kB42.5 kB+58 B (+0.1%)
      size-with-ext-deps63.4 kB63.4 kB+58 B (+0.1%)
    • reauthenticateWithPopup

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size48.5 kB48.5 kB+58 B (+0.1%)
      size-with-ext-deps69.4 kB69.4 kB+58 B (+0.1%)
    • reauthenticateWithRedirect

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size43.4 kB43.5 kB+58 B (+0.1%)
      size-with-ext-deps64.3 kB64.4 kB+58 B (+0.1%)
    • reload

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.3 kB37.4 kB+58 B (+0.2%)
      size-with-ext-deps58.2 kB58.3 kB+58 B (+0.1%)
    • revokeAccessToken

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.4 kB37.5 kB+58 B (+0.2%)
      size-with-ext-deps58.3 kB58.3 kB+58 B (+0.1%)
    • sendEmailVerification

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size38.3 kB38.3 kB+58 B (+0.2%)
      size-with-ext-deps59.2 kB59.2 kB+58 B (+0.1%)
    • sendPasswordResetEmail

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size41.7 kB41.7 kB+58 B (+0.1%)
      size-with-ext-deps62.6 kB62.6 kB+58 B (+0.1%)
    • sendSignInLinkToEmail

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size41.7 kB41.8 kB+58 B (+0.1%)
      size-with-ext-deps62.6 kB62.7 kB+58 B (+0.1%)
    • setPersistence

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.4 kB37.4 kB+58 B (+0.2%)
      size-with-ext-deps58.3 kB58.3 kB+58 B (+0.1%)
    • signInAnonymously

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size38.5 kB38.6 kB+58 B (+0.2%)
      size-with-ext-deps59.4 kB59.5 kB+58 B (+0.1%)
    • signInWithCredential

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size38.7 kB38.8 kB+58 B (+0.1%)
      size-with-ext-deps59.6 kB59.7 kB+58 B (+0.1%)
    • signInWithCustomToken

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size38.4 kB38.4 kB+58 B (+0.2%)
      size-with-ext-deps59.2 kB59.3 kB+58 B (+0.1%)
    • signInWithEmailAndPassword

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size46.0 kB46.1 kB+58 B (+0.1%)
      size-with-ext-deps67.2 kB67.2 kB+58 B (+0.1%)
    • signInWithEmailLink

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size46.0 kB46.1 kB+58 B (+0.1%)
      size-with-ext-deps67.2 kB67.2 kB+58 B (+0.1%)
    • signInWithPhoneNumber

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size42.3 kB42.3 kB+58 B (+0.1%)
      size-with-ext-deps63.2 kB63.2 kB+58 B (+0.1%)
    • signInWithPopup

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size48.4 kB48.5 kB+58 B (+0.1%)
      size-with-ext-deps69.4 kB69.4 kB+58 B (+0.1%)
    • signInWithRedirect

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size43.1 kB43.2 kB+58 B (+0.1%)
      size-with-ext-deps64.0 kB64.1 kB+58 B (+0.1%)
    • signOut

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.4 kB37.4 kB+58 B (+0.2%)
      size-with-ext-deps58.2 kB58.3 kB+58 B (+0.1%)
    • unlink

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.9 kB38.0 kB+58 B (+0.2%)
      size-with-ext-deps58.8 kB58.9 kB+58 B (+0.1%)
    • updateCurrentUser

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.4 kB37.4 kB+58 B (+0.2%)
      size-with-ext-deps58.3 kB58.3 kB+58 B (+0.1%)
    • updateEmail

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.7 kB37.7 kB+58 B (+0.2%)
      size-with-ext-deps58.5 kB58.6 kB+58 B (+0.1%)
    • updatePassword

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.7 kB37.7 kB+58 B (+0.2%)
      size-with-ext-deps58.5 kB58.6 kB+58 B (+0.1%)
    • updatePhoneNumber

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size38.1 kB38.2 kB+58 B (+0.2%)
      size-with-ext-deps59.0 kB59.0 kB+58 B (+0.1%)
    • updateProfile

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.9 kB37.9 kB+58 B (+0.2%)
      size-with-ext-deps58.7 kB58.8 kB+58 B (+0.1%)
    • useDeviceLanguage

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.4 kB37.4 kB+58 B (+0.2%)
      size-with-ext-deps58.3 kB58.3 kB+58 B (+0.1%)
    • validatePassword

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size37.4 kB37.5 kB+58 B (+0.2%)
      size-with-ext-deps58.3 kB58.3 kB+58 B (+0.1%)
    • verifyBeforeUpdateEmail

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size38.3 kB38.4 kB+58 B (+0.2%)
      size-with-ext-deps59.2 kB59.2 kB+58 B (+0.1%)
    • verifyPasswordResetCode

      Size

      TypeBase (a89e05b)Merge (0d6fc74)Diff
      size38.7 kB38.7 kB+58 B (+0.2%)
      size-with-ext-deps59.5 kB59.6 kB+58 B (+0.1%)

Test Logs

google-oss-bot avatar Oct 27 '23 00:10 google-oss-bot

@kevinthecheung @hsubox76 @DellaBitta PTAL, thanks!

prameshj avatar Nov 09 '23 17:11 prameshj

+1

SxtTxch avatar Nov 25 '25 17:11 SxtTxch