firebase-js-sdk icon indicating copy to clipboard operation
firebase-js-sdk copied to clipboard

Auth - OauthProvider "continue to the app"

Open Macacoazul01 opened this issue 4 years ago • 20 comments
trafficstars

Feature proposal

  • Firebase Component: Auth

Opening this issue to request the removal of the "Continue to the app" screen that appears before the provider when using OAuthProvider(providerID: "provider")

(or at least adding the possibility to make it optional)

Sample when executing with twitter: continue

This screen confuses the user, because tapping on the button closes the auth flow and also causes an unnecessary delay to present the provider screen

Gif showing the full flow: Simulator Screen Recording - iPhone 12 Pro - 2021-09-05 at 20

Macacoazul01 avatar Sep 05 '21 20:09 Macacoazul01

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

google-oss-bot avatar Sep 05 '21 20:09 google-oss-bot

Hi @Macacoazul01, thanks for filing this request. Unfortunately the button is necessary to avoid issues with redirects without user interaction. We cannot remove it easily because it may break in non-obvious ways for different users on different devices. With that said, we will keep the issue open for now and mark it as a feature request so that others may chime in if they wish.

sam-gc avatar Sep 08 '21 21:09 sam-gc

@sam-gc Is there any possibility to add a parameter to make that button optional?

Macacoazul01 avatar Sep 08 '21 21:09 Macacoazul01

@sam-gc I think the problem here is that the button closes the authentication flow even though it reads "continue to app" rather than "cancel". So a user would click the button thinking they are proceeding with the authentication but it would close it and raise an error message instead. The logic behaviour would be for the button to redirect to the authentication flow.

guigoruiz1 avatar Sep 08 '21 21:09 guigoruiz1

@sam-gc I think the problem here is that the button closes the authentication flow even though it reads "continue to app" rather than "cancel". So a user would click the button thinking they are proceeding with the authentication but it would close it and raise an error message instead. The logic behaviour would be for the button to redirect to the authentication flow.

Like @guigoruiz1 said, the current text is very ambiguous and can confuse the user

Macacoazul01 avatar Sep 08 '21 21:09 Macacoazul01

@sam-gc and also if you use the normal flow for facebook and google logins there's nothing like this page. So why it exists here?

Macacoazul01 avatar Oct 27 '21 18:10 Macacoazul01

Personally, I don't mind this page if it's technically required, but would love some way to style it, like injecting some CSS to make it look more like the app.

hesselbom avatar Apr 12 '22 11:04 hesselbom

Seems to be web related feature request, moved it from /firebase-ios-sdk to /firebase-js-sdk

yoyomyo avatar May 05 '22 21:05 yoyomyo

@yoyomyo seems easy to solve?

Macacoazul01 avatar May 05 '22 23:05 Macacoazul01

The "continue to app" button is only shown if the intermediate page (<your-project>.firebaseapp.com/__/auth/handler) doesn't close properly (due to e.g. browser not allowing the JS to close the window). Therefore it would be a regression to remove this button as the user would have no way of returning to the app---the issue in this case is often that the browser needs the user to initiate the close-page / redirect action

sam-gc avatar May 06 '22 16:05 sam-gc

We can reopen this actually to track the feature request to make it styleable and customizable. Please note though that this is not currently on our roadmap and I can't make any promises about when it may be

sam-gc avatar May 06 '22 16:05 sam-gc

The "continue to app" button is only shown if the intermediate page (.firebaseapp.com/__/auth/handler) doesn't close properly (due to e.g. browser not allowing the JS to close the window). Therefore it would be a regression to remove this button as the user would have no way of returning to the app---the issue in this case is often that the browser needs the user to initiate the close-page / redirect action

the intermediate page closes by itself, I can record another video if necessary.

If the page doesn't close by itself is a dev side problem not something that the user should have to do/see. Why not to provide at least an option on the call to block this button from appearing?

Macacoazul01 avatar May 08 '22 00:05 Macacoazul01

The button exists because there is an issue in some browsers/situations where the page won't close/redirect, and there's nothing the client-side app can do about it (the user simply is required to interact, and the handler is not in client code).

There should be a 1 second delay before the button is shown, so if you're seeing it sooner that is indeed a bug.

sam-gc avatar May 09 '22 16:05 sam-gc

The "Continue to the app" is really confusing, ugly and make users click it. It would be great to customize it or delay its displaying.

I'm implementing "Sign in with Apple" and the button only is displayed for several seconds even on fast internet.

omgovich avatar Sep 26 '23 15:09 omgovich

On mobiles it is the only content on the screen for X seconds (why not display a spinner?): CleanShot 2023-09-26 at 17 49 24@2x

On desktops it's always visible and distracts users: CleanShot 2023-09-26 at 17 48 32@2x

omgovich avatar Sep 26 '23 15:09 omgovich

2 years later this issue is still not solved.

iamorlando avatar Oct 07 '23 04:10 iamorlando

Hey @sam-gc would love a way to style the button indeed.

Is there a hack around it for the moment? would just want to perform very simple css to it.

Thank you!

rayanoncyber avatar Nov 17 '23 11:11 rayanoncyber

For example, this issue leads to denial of my PWA app in Apple

gspassky avatar Apr 08 '24 19:04 gspassky

Guys, any options to style this page ? Still searching for the way how to handle it

Nikita-schetko avatar Apr 16 '24 09:04 Nikita-schetko

Zero options 3 years later

Macacoazul01 avatar Apr 16 '24 14:04 Macacoazul01