firebase-ios-sdk icon indicating copy to clipboard operation
firebase-ios-sdk copied to clipboard

[Auth]: Add auth state stream utility

Open nidegen opened this issue 8 months ago • 4 comments

Hi there!

Not sure if API extensions are also not allowed, but I figured this little helper could be useful to add some concurrency in Auth.

The struct AuthState is only there to avoid concurrency issues that appear when using a tuple instead.

nidegen avatar Mar 28 '25 17:03 nidegen

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments to provide feedback.

gemini-code-assist[bot] avatar Mar 28 '25 17:03 gemini-code-assist[bot]

/gemini review

nidegen avatar Mar 28 '25 17:03 nidegen

Thanks for the PR, @nidegen! Are there use cases where you were intending to use the stream API? As a 1:1 replacement for the callback listener or perhaps in SwiftUI views?

ncooke3 avatar Apr 02 '25 16:04 ncooke3

Just as a 1:1 replacement for the callback listener initially but definitely with SwiftUI tasks in mind:)

Not a big pain point, but I thought it might be welcome!

nidegen avatar Apr 02 '25 21:04 nidegen

Is this still considered? Was thinking of adding similar streams to firestore listeners too.

But happy to close it if it is out of scope:)

nidegen avatar Jun 24 '25 14:06 nidegen

Thanks @nidegen, sorry for the delay, but yes this is still being considered. In the last few weeks, we've been putting together guidance for streaming API design. Once that is finalized, we will review this. Apologies again for the delay.

ncooke3 avatar Jun 24 '25 17:06 ncooke3