firebase-ios-sdk
firebase-ios-sdk copied to clipboard
Create buildable branch for Swift 6 and Xcode 16+
Disables a bunch of GHA tests and marks much of the existing code as @unchecked Sendable. These will eventually need to be fixed but for now we can kick them down the road and still have Swift 6 compliance. There's some improvements in this PR too: addition of a safer os_unfair_lock in FIRAllocatedUnfairLock, which we can drop once we get to iOS 16+, and some fixes to things that could not have possibly worked before but somehow did.
To find @unchecked Sendable types that need to be made checked Sendable or refactored, search for /* TODO: sendable */.
To find disabled tests that need to be re-enabled, search for # TODO(Swift 6):.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments to provide feedback.
This PR has been fully merged in piecemeal format by Nick at this point.