Recent fixes + improvements to FIRDatabaseQuery#getDataWithCompletionBlock

[jmwski]

trafficstars

This change includes fixes ported from:

• https://github.com/firebase/firebase-android-sdk/pull/3887
• https://github.com/firebase/firebase-android-sdk/pull/3962
• https://github.com/firebase/firebase-android-sdk/pull/3485

Highlights:

• FSyncTree {add, remove}EventRegistration now have skipListenDedup and skipListenSetup which are set to true by keepQuery if it's being called to establish a short-lived View to update persistent cache in getDataWithCompletionBlock.
• The branch in FPersistentConnection that waits for a connection to be established is now removed. The first getDataWithCompletionBlock will block until initial connect. Every get() thereafter fallback to persisted cache in the worst case.

[google-oss-bot]

	1 Warning
:warning:	Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by :no_entry_sign: Danger

[google-oss-bot]

Coverage Report ¹

Affected Products

• FirebaseDatabase-iOS-FirebaseDatabase.framework

  Overall coverage changed from 56.99% (09aae23) to 56.91% (e29350b) by -0.08%.

  Filename	Base (09aae23)	Merge (e29350b)	Diff
  FPersistentConnection.m	21.28%	21.81%	+0.54%
  FRepo.m	13.49%	13.01%	-0.48%
  FSyncTree.m	71.33%	70.87%	-0.46%

Test Logs

• Base (09aae23): https://github.com/firebase/firebase-ios-sdk/actions/runs/4196227029
• Merge (e29350b): https://github.com/firebase/firebase-ios-sdk/actions/runs/4197854841

1. https://storage.googleapis.com/firebase-sdk-metric-reports/NhDOson65n.html

[paulb777]

• @aashishpatil-g Please close, merge, or comment. We plan to close stale PRs on November 28, 2023.

[aashishpatil-g]

@paulb777 - We are still actively considering this PR for merge.

[maneesht]

Closing. Will re-open once the master branch is re-named.