firebase-functions-test icon indicating copy to clipboard operation
firebase-functions-test copied to clipboard

Published 20 hours ago • verified publisher icon firebase

Drop legacy import/export syntax

Open merlinnot opened this issue 6 years ago • 3 comments
trafficstars

This package uses legacy import/export syntax, the proposal was withdrawn and this syntax should not be used:

https://github.com/firebase/firebase-functions-test/blob/a25faf5c87553b4482ce85a7dea4d11885f27cc4/src/index.ts#L29

https://github.com/firebase/firebase-functions-test/blob/c77aa92d345b8e4fb5ad98534989eb8dcf7d9bc4/spec/providers/https.spec.ts#L3

We could either use default export, or preferably a named one, but it would be a breaking change, so I won't make a PR before we align on this.

merlinnot avatar Mar 11 '19 18:03 merlinnot

Absolutely agreed, I'll probably snap this twig on the next major release.

abeisgoat avatar Mar 12 '19 19:03 abeisgoat

@abeisgoat Is this package still maintained? Is it worth to start making PRs?

merlinnot avatar Oct 03 '19 20:10 merlinnot

Hey @merlinnot sorry for the long silence! We've definitely dropped the ball on our side, and will start showing this repo some more love. Yes you're very welcome to start making PRs, and we'd be happy to review.

laurenzlong avatar Dec 14 '19 00:12 laurenzlong