Fixed the missing handling setter annotations bug

[cherylEnkidu]

Restore PR: https://github.com/firebase/firebase-android-sdk/pull/5626

The majority of the code in this PR was contributed by vladd-g

For more context, please refer to the linked PR.

[github-actions[bot]]

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

[google-oss-bot]

Coverage Report ¹

Affected Products

• firebase-database

  Overall coverage changed from 50.13% (1140948) to 50.12% (6bf7926) by -0.01%.

  Filename	Base (1140948)	Merge (6bf7926)	Diff
  CustomClassMapper.java	88.33%	88.52%	+0.19%
  QueryParams.java	90.36%	89.76%	-0.60%
  ViewProcessor.java	91.79%	92.10%	+0.30%
  WebsocketConnection.java	35.03%	32.77%	-2.26%

• firebase-firestore

  Overall coverage changed from 44.84% (1140948) to 44.86% (6bf7926) by +0.02%.

  Filename	Base (1140948)	Merge (6bf7926)	Diff
  CustomClassMapper.java	84.25%	84.44%	+0.19%
  DeleteMutation.java	90.48%	95.24%	+4.76%
  SetMutation.java	94.44%	97.22%	+2.78%

Test Logs

• Base (1140948): https://github.com/firebase/firebase-android-sdk/actions/runs/7904500030
• Merge (6bf7926): https://github.com/firebase/firebase-android-sdk/actions/runs/7924370982

1. https://storage.googleapis.com/firebase-sdk-metric-reports/oGvSUwtxPK.html

[github-actions[bot]]

Unit Test Results

   250 files  +   210     250 suites  +210   5m 10s :stopwatch: + 3m 54s 1 644 tests +1 334  1 626 :heavy_check_mark: +1 316  18 :zzz: +18  0 :x: ±0  3 338 runs  +2 706  3 302 :heavy_check_mark: +2 670  36 :zzz: +36  0 :x: ±0 

Results for commit f0273273. ± Comparison against base commit 11409488.

This pull request removes 310 and adds 1644 tests. Note that renamed tests count towards both.

com.google.firebase.remoteconfig.ConfigTests ‑ Firebase#remoteConfig should delegate to FirebaseRemoteConfig#getInstance()
com.google.firebase.remoteconfig.ConfigTests ‑ Firebase#remoteConfig should delegate to FirebaseRemoteConfig#getInstance(FirebaseApp, region)
com.google.firebase.remoteconfig.ConfigTests ‑ FirebaseRemoteConfigSettings builder works
com.google.firebase.remoteconfig.ConfigTests ‑ Overloaded get() operator returns default value when key doesn't exist
com.google.firebase.remoteconfig.ConfigTests ‑ Overloaded get() operator returns value when key exists
com.google.firebase.remoteconfig.FirebaseRemoteConfigSettingsTest ‑ toBuilder_withFieldsSet_buildsObjectWithFieldsSet
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate2p_hasAbtExperiments_doesNotCallAbt
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate2p_hasNoAbtExperiments_doesNotCallAbt
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_callToAbtFails_activateStillSucceeds
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_configWithRolloutMetadata_storedInActivatedCacheSuccessfully
…

com.google.firebase.TimestampTest ‑ testCompare
com.google.firebase.TimestampTest ‑ testFromDate
com.google.firebase.TimestampTest ‑ testRejectBadDates
com.google.firebase.TimestampTest ‑ testTimestampParcelable
com.google.firebase.database.DataSnapshotTest ‑ basicIterationWorks
com.google.firebase.database.DataSnapshotTest ‑ existsWorks
com.google.firebase.database.DataSnapshotTests ‑ reified getValue works with basic types
com.google.firebase.database.DataSnapshotTests ‑ reified getValue works with custom types
com.google.firebase.database.DataSnapshotTests ‑ reified getValue works with lists types
com.google.firebase.database.DataSnapshotTests ‑ reified getValue works with maps
…

:recycle: This comment has been updated with latest results.

[google-oss-bot]

Size Report ¹

Affected Products

• firebase-database

  Type	Base (1140948)	Merge (6bf7926)	Diff
  aar	537 kB	537 kB	+120 B (+0.0%)
  apk (release)	5.39 MB	5.40 MB	+96 B (+0.0%)

• firebase-firestore

  Type	Base (1140948)	Merge (6bf7926)	Diff
  aar	1.41 MB	1.41 MB	+137 B (+0.0%)
  apk (release)	11.4 MB	11.4 MB	+100 B (+0.0%)

Test Logs

• Base (1140948): https://github.com/firebase/firebase-android-sdk/actions/runs/7904500030
• Merge (6bf7926): https://github.com/firebase/firebase-android-sdk/actions/runs/7924370982

1. https://storage.googleapis.com/firebase-sdk-metric-reports/2JgXZKIhez.html

[google-oss-bot]

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

• This report is for comparing the base commit (1140948) and the CI merge commit (6bf7926)
• Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
  • 1140948: https://storage.googleapis.com/firebase-sdk-metric-reports/aG0XHpbbm7/index.html
  • 6bf7926: https://storage.googleapis.com/firebase-sdk-metric-reports/MBI0vQHoBZ/index.html

Startup Times

• fire-fst

  Device	Statistics	Distributions
  oriole-32	Percentile 1140948 6bf7926 Diff Significant (?) p10 580 ±256 μs 320 ±18 μs -260 μs (-44.8%) NO p25 608 ±258 μs 335 ±22 μs -273 μs (-45.0%) NO p50 658 ±246 μs 373 ±55 μs -284 μs (-43.2%) NO p75 718 ±225 μs 457 ±105 μs -260 μs (-36.3%) NO p90 816 ±214 μs 613 ±233 μs -203 μs (-24.8%) NO 20 test runs in comparison Commit Test Runs 1140948 2024-02-14_16:55:45.174079_Cwyz 2024-02-14_16:55:45.174124_zYcN 2024-02-14_16:55:45.174136_yoOx 2024-02-14_16:55:45.174145_aTNg 2024-02-14_16:55:45.174154_FcFA 2024-02-14_16:55:45.174163_Tqgl 2024-02-14_16:55:45.174180_WkqB 2024-02-14_16:55:45.174187_hvgh 2024-02-14_16:55:45.174194_DDzk 2024-02-14_16:55:45.174201_GcCu 6bf7926 2024-02-17_05:47:25.081876_KVSf 2024-02-17_05:47:25.081911_iFxZ 2024-02-17_05:47:25.081922_JVFL 2024-02-17_05:47:25.081928_kVOh 2024-02-17_05:47:25.081933_zhmi 2024-02-17_05:47:25.081937_jXgm 2024-02-17_05:47:25.081941_zpYl 2024-02-17_05:47:25.081945_voqa 2024-02-17_05:47:25.081949_InUt 2024-02-17_05:47:25.081953_uEvk
  redfin-30	Percentile 1140948 6bf7926 Diff Significant (?) p10 712 ±210 μs 604 ±39 μs -107 μs (-15.1%) NO p25 734 ±208 μs 624 ±42 μs -110 μs (-15.0%) NO p50 763 ±203 μs 657 ±52 μs -106 μs (-13.9%) NO p75 810 ±203 μs 696 ±61 μs -114 μs (-14.1%) NO p90 876 ±208 μs 760 ±87 μs -116 μs (-13.3%) NO 20 test runs in comparison Commit Test Runs 1140948 2024-02-14_16:55:45.174079_Cwyz 2024-02-14_16:55:45.174124_zYcN 2024-02-14_16:55:45.174136_yoOx 2024-02-14_16:55:45.174145_aTNg 2024-02-14_16:55:45.174154_FcFA 2024-02-14_16:55:45.174163_Tqgl 2024-02-14_16:55:45.174180_WkqB 2024-02-14_16:55:45.174187_hvgh 2024-02-14_16:55:45.174194_DDzk 2024-02-14_16:55:45.174201_GcCu 6bf7926 2024-02-17_05:47:25.081876_KVSf 2024-02-17_05:47:25.081911_iFxZ 2024-02-17_05:47:25.081922_JVFL 2024-02-17_05:47:25.081928_kVOh 2024-02-17_05:47:25.081933_zhmi 2024-02-17_05:47:25.081937_jXgm 2024-02-17_05:47:25.081941_zpYl 2024-02-17_05:47:25.081945_voqa 2024-02-17_05:47:25.081949_InUt 2024-02-17_05:47:25.081953_uEvk

• fire-rtdb

  Device	Statistics	Distributions
  oriole-32	Percentile 1140948 6bf7926 Diff Significant (?) p10 32.5 ±4 μs 36.2 ±7 μs +3.73 μs (+11.5%) NO p25 37.4 ±9 μs 39.1 ±8 μs +1.69 μs (+4.5%) NO p50 139 ±209 μs 44.6 ±12 μs -94.8 μs (-68.0%) NO p75 153 ±214 μs 53.5 ±20 μs -99.6 μs (-65.0%) NO p90 173 ±221 μs 76.5 ±44 μs -96.6 μs (-55.8%) NO 20 test runs in comparison Commit Test Runs 1140948 2024-02-14_16:55:45.174079_Cwyz 2024-02-14_16:55:45.174124_zYcN 2024-02-14_16:55:45.174136_yoOx 2024-02-14_16:55:45.174145_aTNg 2024-02-14_16:55:45.174154_FcFA 2024-02-14_16:55:45.174163_Tqgl 2024-02-14_16:55:45.174180_WkqB 2024-02-14_16:55:45.174187_hvgh 2024-02-14_16:55:45.174194_DDzk 2024-02-14_16:55:45.174201_GcCu 6bf7926 2024-02-17_05:47:25.081876_KVSf 2024-02-17_05:47:25.081911_iFxZ 2024-02-17_05:47:25.081922_JVFL 2024-02-17_05:47:25.081928_kVOh 2024-02-17_05:47:25.081933_zhmi 2024-02-17_05:47:25.081937_jXgm 2024-02-17_05:47:25.081941_zpYl 2024-02-17_05:47:25.081945_voqa 2024-02-17_05:47:25.081949_InUt 2024-02-17_05:47:25.081953_uEvk
  redfin-30	Percentile 1140948 6bf7926 Diff Significant (?) p10 71.5 ±12 μs 80.9 ±15 μs +9.41 μs (+13.2%) NO p25 76.2 ±11 μs 84.9 ±14 μs +8.75 μs (+11.5%) NO p50 83.7 ±10 μs 91.3 ±14 μs +7.64 μs (+9.1%) NO p75 94.1 ±10 μs 101 ±13 μs +6.73 μs (+7.2%) NO p90 121 ±29 μs 119 ±14 μs -1.44 μs (-1.2%) NO 20 test runs in comparison Commit Test Runs 1140948 2024-02-14_16:55:45.174079_Cwyz 2024-02-14_16:55:45.174124_zYcN 2024-02-14_16:55:45.174136_yoOx 2024-02-14_16:55:45.174145_aTNg 2024-02-14_16:55:45.174154_FcFA 2024-02-14_16:55:45.174163_Tqgl 2024-02-14_16:55:45.174180_WkqB 2024-02-14_16:55:45.174187_hvgh 2024-02-14_16:55:45.174194_DDzk 2024-02-14_16:55:45.174201_GcCu 6bf7926 2024-02-17_05:47:25.081876_KVSf 2024-02-17_05:47:25.081911_iFxZ 2024-02-17_05:47:25.081922_JVFL 2024-02-17_05:47:25.081928_kVOh 2024-02-17_05:47:25.081933_zhmi 2024-02-17_05:47:25.081937_jXgm 2024-02-17_05:47:25.081941_zpYl 2024-02-17_05:47:25.081945_voqa 2024-02-17_05:47:25.081949_InUt 2024-02-17_05:47:25.081953_uEvk

• timeToInitialDisplay

  Device	Statistics	Distributions
  oriole-32	Percentile 1140948 6bf7926 Diff Significant (?) p10 204 ±5 ms 208 ±3 ms +4.52 ms (+2.2%) NO p25 211 ±5 ms 215 ±3 ms +4.21 ms (+2.0%) NO p50 218 ±6 ms 223 ±2 ms +4.64 ms (+2.1%) NO p75 226 ±7 ms 233 ±3 ms +6.85 ms (+3.0%) NO p90 234 ±7 ms 244 ±4 ms +9.36 ms (+4.0%) NO 20 test runs in comparison Commit Test Runs 1140948 2024-02-14_16:55:45.174079_Cwyz 2024-02-14_16:55:45.174124_zYcN 2024-02-14_16:55:45.174136_yoOx 2024-02-14_16:55:45.174145_aTNg 2024-02-14_16:55:45.174154_FcFA 2024-02-14_16:55:45.174163_Tqgl 2024-02-14_16:55:45.174180_WkqB 2024-02-14_16:55:45.174187_hvgh 2024-02-14_16:55:45.174194_DDzk 2024-02-14_16:55:45.174201_GcCu 6bf7926 2024-02-17_05:47:25.081876_KVSf 2024-02-17_05:47:25.081911_iFxZ 2024-02-17_05:47:25.081922_JVFL 2024-02-17_05:47:25.081928_kVOh 2024-02-17_05:47:25.081933_zhmi 2024-02-17_05:47:25.081937_jXgm 2024-02-17_05:47:25.081941_zpYl 2024-02-17_05:47:25.081945_voqa 2024-02-17_05:47:25.081949_InUt 2024-02-17_05:47:25.081953_uEvk
  redfin-30	Percentile 1140948 6bf7926 Diff Significant (?) p10 250 ±5 ms 272 ±5 ms +22.4 ms (+8.9%) MAYBE p25 256 ±6 ms 278 ±5 ms +22.0 ms (+8.6%) MAYBE p50 265 ±7 ms 286 ±4 ms +21.1 ms (+8.0%) NO p75 275 ±11 ms 295 ±5 ms +19.6 ms (+7.1%) NO p90 286 ±13 ms 307 ±8 ms +21.4 ms (+7.5%) NO 20 test runs in comparison Commit Test Runs 1140948 2024-02-14_16:55:45.174079_Cwyz 2024-02-14_16:55:45.174124_zYcN 2024-02-14_16:55:45.174136_yoOx 2024-02-14_16:55:45.174145_aTNg 2024-02-14_16:55:45.174154_FcFA 2024-02-14_16:55:45.174163_Tqgl 2024-02-14_16:55:45.174180_WkqB 2024-02-14_16:55:45.174187_hvgh 2024-02-14_16:55:45.174194_DDzk 2024-02-14_16:55:45.174201_GcCu 6bf7926 2024-02-17_05:47:25.081876_KVSf 2024-02-17_05:47:25.081911_iFxZ 2024-02-17_05:47:25.081922_JVFL 2024-02-17_05:47:25.081928_kVOh 2024-02-17_05:47:25.081933_zhmi 2024-02-17_05:47:25.081937_jXgm 2024-02-17_05:47:25.081941_zpYl 2024-02-17_05:47:25.081945_voqa 2024-02-17_05:47:25.081949_InUt 2024-02-17_05:47:25.081953_uEvk

1. https://storage.googleapis.com/firebase-sdk-metric-reports/JBpKwTobPl/index.html