firebase-android-sdk
firebase-android-sdk copied to clipboard
firebase
Resolve StrictMode violation in App Check.
Resolve a StrictMode violation in App Check by moving the retrieval of the stored App Check token out of the initialization path.
Size Report 1
Affected Products
firebase-appcheckType Base (6df92b9) Merge (5275ef4) Diff aar 37.1 kB 37.3 kB +202 B (+0.5%) apk (aggressive) 332 kB 332 kB +136 B (+0.0%) apk (release) 977 kB 977 kB +768 B (+0.1%)
Test Logs
- Base (6df92b9): https://github.com/firebase/firebase-android-sdk/actions/runs/3063326347
- Merge (5275ef4): https://github.com/firebase/firebase-android-sdk/actions/runs/3070153384
Coverage Report 1
Affected Products
firebase-appcheckOverall coverage changed from 81.39% (6df92b9) to 81.84% (5275ef4) by +0.45%.
Filename Base (6df92b9) Merge (5275ef4) Diff DefaultFirebaseAppCheck.java 81.63% 83.62% +1.99%
Test Logs
- Base (6df92b9): https://github.com/firebase/firebase-android-sdk/actions/runs/3063326347
- Merge (5275ef4): https://github.com/firebase/firebase-android-sdk/actions/runs/3070153384
Unit Test Results
232 tests +232 232 :heavy_check_mark: +232 1m 28s :stopwatch: + 1m 28s 40 suites + 40 0 :zzz: ± 0 40 files + 40 0 :x: ± 0
Results for commit ef3dbb15. ± Comparison against base commit e6226b74.
:recycle: This comment has been updated with latest results.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@vkryachko are the Firebase Storage unit tests known to be flaky? They all pass every time when I run them locally, but they seem to be failing in the presubmits here (specifically UploadTest). I got the unit test presubmit to run on previous commits after re-running them several times, but the Health Metrics / Coverage tests are consistently failing.
Yes, storage has been really flaky lately, Health Metrics are non-blocking, so no need to worry about them
