firebase-android-sdk icon indicating copy to clipboard operation
firebase-android-sdk copied to clipboard

RTDB Optimization: Set initial capacity of the string builder

Open jsdt opened this issue 3 years ago • 2 comments

This is a minor optimization to reduce some allocations in the RTDB client.

jsdt avatar May 05 '22 22:05 jsdt

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.21% (889bf9a) to 50.16% (38b4c2c) by -0.05%.

    FilenameBase (889bf9a)Merge (38b4c2c)Diff
    BooleanNode.java92.31%100.00%+7.69%
    ChildChangeAccumulator.java96.67%83.33%-13.33%

Test Logs

Notes

  • Commit (38b4c2c) is created by Prow via merging PR base commit (889bf9a) and head commit (27ca577).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

google-oss-bot avatar May 05 '22 22:05 google-oss-bot

Size Report 1

Affected Products

  • firebase-database

    TypeBase (889bf9a)Merge (38b4c2c)Diff
    aar488 kB488 kB+63 B (+0.0%)
    apk (release)1.14 MB1.14 MB+96 B (+0.0%)

Test Logs

Notes

  • Commit (38b4c2c) is created by Prow via merging PR base commit (889bf9a) and head commit (27ca577).

google-oss-bot avatar May 05 '22 22:05 google-oss-bot