firebase-admin-node icon indicating copy to clipboard operation
firebase-admin-node copied to clipboard

updating comments for VibrateTimingsMillis and defaultVibrateTiming

Open younes-makhchan opened this issue 1 year ago • 4 comments

This PR is intended to update the comments for VibrateTimingsMillis and defaultVibrateTimings as the names changed from vibrate_timings to VibrateTimingsMillis and default_vibrate_timings to defaultVibrateTimings

As it's updated in the Firebase Docs :

younes-makhchan avatar Jun 17 '24 17:06 younes-makhchan

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 17 '24 17:06 google-cla[bot]

Thank you for your contribution! Could you fix the CLA issues, please?

lahirumaramba avatar Jun 19 '24 17:06 lahirumaramba

@lahirumaramba Thank you for notifying Me , i have fixed the CLA issue

younes-makhchan avatar Jun 20 '24 11:06 younes-makhchan

@lahirumaramba can i get a review, please?

younes-makhchan avatar Jun 30 '24 13:06 younes-makhchan