firebase-admin-go icon indicating copy to clipboard operation
firebase-admin-go copied to clipboard

feat(fcm): Set FCMOptions for MulticastMessage

Open FZambia opened this issue 2 years ago • 8 comments
trafficstars

Hello!

Currently it's impossible to set FCMOptions for MulticastMessage. While for example in Python admin SDK this is possible. And in Java admin SDK. This pull request fixes this.

FZambia avatar Feb 11 '23 17:02 FZambia

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Feb 11 '23 17:02 google-cla[bot]

CLA signed

FZambia avatar Feb 15 '23 12:02 FZambia

Hi @FZambia Thank you for your contribution. Please change the base branch to dev before we can start the review process.

https://github.com/firebase/firebase-admin-go/blob/master/CONTRIBUTING.md#want-to-submit-a-pull-request

Make sure to create all your pull requests against the dev branch. All development work takes place on this branch, while the master branch is dedicated for released stable code. This enables us to review and merge routine code changes, without impacting downstream applications that are building against our master branch.

lahirumaramba avatar Mar 24 '23 17:03 lahirumaramba

Hello team, could you please tell when this will be released?

FZambia avatar May 13 '23 16:05 FZambia

@lahirumaramba - any updates?

FZambia avatar Jun 10 '23 07:06 FZambia

Guys, at least explain what prevents you from merging this?

FZambia avatar Dec 27 '23 09:12 FZambia

LGTM But I'd like to ask for waiting until @lahirumaramba 's review

chong-shao avatar Dec 28 '23 05:12 chong-shao

This would be nice to finally have in the package. @lahirumaramba can you please have a look at this minor change as it's only two lines of code and almost a year open?

sebastianbuechler avatar Jan 18 '24 07:01 sebastianbuechler

@lahirumaramba kindly reminding 🙏

FZambia avatar Mar 03 '24 07:03 FZambia

Thanks folks! This change will be included in the next release

lahirumaramba avatar Mar 11 '24 19:03 lahirumaramba

Nice, many thanks!

FZambia avatar Mar 12 '24 04:03 FZambia