extensions icon indicating copy to clipboard operation
extensions copied to clipboard

🐛 [storage-resize-images] Extension crops the image with default settings.

Open mehmet2006 opened this issue 1 year ago • 2 comments

[READ] Step 1: Are you in the right place?

Issues filed here should be about bugs for a specific extension in this repository. If you have a general question, need help debugging, or fall into some other category use one of these other channels:

  • For general technical questions, post a question on StackOverflow with the firebase tag.
  • For general Firebase discussion, use the firebase-talk google group.
  • To file a bug against the Firebase Extensions platform, or for an issue affecting multiple extensions, please reach out to Firebase support directly.

[REQUIRED] Step 2: Describe your configuration

  • Extension name: storage-resize-images (storage-resize-images, firestore-send-email, etc)
  • Extension version: 0.2.5
  • Configuration values (redact info where appropriate):
    • _
    • _

[REQUIRED] Step 3: Describe the problem

In the documentation it says, it will keep the aspect ratio when resizing images. But currently it doesn't. It crops the image

Steps to reproduce:

1- Install the extension 2- Add 300x300, 756x756, 900x900 image resolutions 3- What the installation finished 4- Upload an image 5- Check the results

Expected result

Images should have been resized with the same aspect ratio and crop should have happen

Actual result

Images lost their aspect ratio and and it is cropped

mehmet2006 avatar May 31 '24 08:05 mehmet2006

@mehmet2006 did you find a workaround for this? I'm also experiencing the same problem!

gregives avatar Jun 13 '24 07:06 gregives

I've submitted a pull request to fix this issue. If anyone needs a workaround in the meantime, change this setting in the configuration of the extension.

Sharp constructor options for resizing images

{ "fit": "inside" }

gregives avatar Jun 13 '24 08:06 gregives

I'm having the same issue.

I've submitted a pull request to fix this issue. If anyone needs a workaround in the meantime, change this setting in the configuration of the extension.

Sharp constructor options for resizing images

{ "fit": "inside" }

I tried following @gregives solution by adding the setting for the Sharp constructor but there's an error on save. Version: 0.2.6

Image

GeorgEduard avatar Jan 17 '25 07:01 GeorgEduard

@GeorgEduard I am also using version 0.2.6 with that parameter and it seems to be working fine! Did you change any other parameters at the same time that could be causing the error?

gregives avatar Jan 17 '25 11:01 gregives

@GeorgEduard I am also using version 0.2.6 with that parameter and it seems to be working fine! Did you change any other parameters at the same time that could be causing the error?

@gregives this is the only thing I'm adding to that field. When I press save, the first time nothing happens, and the second time, the error above appears. Image

GeorgEduard avatar Jan 17 '25 11:01 GeorgEduard

@GeorgEduard that's exactly the same as mine, aside from I have extra spaces which shouldn't make any difference. Have you changed any other options for the extension? I wonder if maybe some options are incompatible?

Image

The only thing I can suggest is resetting all of the options (or uninstalling the extension) and trying again. No idea why it wouldn't be working though!

Other than that, maybe read the setup instructions again (https://extensions.dev/extensions/firebase/storage-resize-images) just in case you missed anything e.g. make sure you have a storage bucket set up, make sure you're on the Blaze plan. Sorry I can't be more help!

gregives avatar Jan 17 '25 11:01 gregives

@gregives We've been using the extension for about 2 years now, only recently I noticed this issue. Not really sure if it was always there, or it's a bug introduced later. I'll double check the settings.

Thanks, anyay! Hopefully it will be fixed in the next update.

GeorgEduard avatar Jan 17 '25 11:01 GeorgEduard

@GeorgEduard how strange! One other thing you could check, does it only happen when you change that option or does it happen when you change other options?

gregives avatar Jan 17 '25 11:01 gregives

Great idea,@gregives. Yeah, it happens when I change other settings too. I might actually need to reinstall it. Thanks!

GeorgEduard avatar Jan 17 '25 11:01 GeorgEduard

@GeorgEduard no problem, I hope you get it sorted!

gregives avatar Jan 17 '25 11:01 gregives

Hi all,

I'm reviewing this and will provide updates when available, thanks for your patience!

cabljac avatar Feb 11 '25 16:02 cabljac