git-proxy icon indicating copy to clipboard operation
git-proxy copied to clipboard

chore: automatically increment version in package.json on new release

Open divinetettey opened this issue 1 year ago • 12 comments

This PR attempts to resolve this issue Automatically increment version in package.json on new release 📦 . The PR aims at automating the update off the version in pacakge.json

  1. A new step has been added to extract the version number from the draft release. this version number is then used in subsequent steps to update the package.json
  2. The extracted version number is used to update the package.json,package-lock.json and the docusaurus.config.js
  3. after update the update a commit is pushed back to the repository

divinetettey avatar Jun 07 '24 16:06 divinetettey

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: divinecodes / name: Divine Tettey (a3e29e073d6ba9a8d2b735bc06c8585fa9f4a604)
  • :white_check_mark: login: JamieSlome / name: Jamie Slome (778c12f1cf2272bcde2fcfd0a9ad688dc834d02f, 7fbc69060f169067304c87d8a4f9522ed22bcbb7, e4b400d33c3329d24c3a35b72a53dc13236f289b, a69cddef901bab3ee814c6b672199662ecca7781, 9d9db92caf96e43cb131ca77dd12bb5fcfa60c1d, 6b86691c3a5515b027734762757e132d45656402)
  • :white_check_mark: login: divinetettey / name: Divine Sedem Tettey (499969adbd43c12d0e22f999630dafbbb44cd7b0, 663e030ed96817652d8ceadf06953e58fca79e69, 0be28b9ef5ca54713215fedc4e54ac721bb67e45, bbf6e0fcfb966be93ba13cf5c5af70376c0b533d, 54a7efe02b3de7f280b4faaede504440dd1ab437, 3e29af9140deb0862288dbc352d583ef7d4f5606, 3cb7cd5c97295624da986b83255cb9e29500df45, cae8f79ea3efe64529b27450a24d5b4021cba1f5, d6bcfa4d3ce6e7814c57ea7eab6b27e9e5f29379, c3576712b494a91706b901e2ca7b07939fdc1cbc, 111457ff0f48eae81bbc5acb37689003734f2cdb, 5f26b9517b0f17d55ca09fe58dba6613fa05a716, b7b8a11b090d46632be7beee788519221b9f2478, 1027f2e1cb5f8b3229782af2d1d3aca0e97aec37, 3ef3465e1e343a857642e49454bcf124b49f666d)

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
Latest commit 54a7efe02b3de7f280b4faaede504440dd1ab437
Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/66633207a7d8a5000830adc6

netlify[bot] avatar Jun 07 '24 16:06 netlify[bot]

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
Latest commit 6b86691c3a5515b027734762757e132d45656402
Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/66fd617d02b9890008718bf3

netlify[bot] avatar Jun 07 '24 16:06 netlify[bot]

Thanks for the PR, @divinetettey 👍 Is there anyway we can update the package.json and package-lock.json version before we run the release? i.e. include the latest version number in the actual release itself

JamieSlome avatar Jun 11 '24 11:06 JamieSlome

Thanks for the PR, @divinetettey 👍 Is there anyway we can update the package.json and package-lock.json version before we run the release? i.e. include the latest version number in the actual release itself

sure, let me take a look at this

divinetettey avatar Jun 14 '24 11:06 divinetettey

Thanks for the PR, @divinetettey 👍 Is there anyway we can update the package.json and package-lock.json version before we run the release? i.e. include the latest version number in the actual release itself

sure, let me take a look at this

should this run before/after the release-drafter

divinetettey avatar Jun 14 '24 13:06 divinetettey

@divinetettey - we want the file bumps to occur before we make the NPM and GitHub releases. This is to ensure that the releases themselves include the correct version number.

JamieSlome avatar Jun 17 '24 12:06 JamieSlome

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.39%. Comparing base (3b6cb6b) to head (6b86691).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #596   +/-   ##
=======================================
  Coverage   57.39%   57.39%           
=======================================
  Files          46       46           
  Lines        1582     1582           
=======================================
  Hits          908      908           
  Misses        674      674           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 18 '24 13:06 codecov[bot]

@divinetettey, the @divinecodes will also need to authorise with EasyCLA to merge this pull request (heads up).

JamieSlome avatar Jun 18 '24 13:06 JamieSlome

@divinetettey, the @divinecodes will also need to authorise with EasyCLA to merge this pull request (heads up).

yeah, my gitconfigs got messed and the commit was pushed with my personal account. I am going to squash the commit and push it with @divinetettey

divinetettey avatar Jun 18 '24 13:06 divinetettey

Happy from my end. @divinetettey - have you been able to test the update_version step?

Yes, getting some failures with release-drafter, taking a look

divinetettey avatar Jun 20 '24 16:06 divinetettey

Happy from my end. @divinetettey - have you been able to test the update_version step?

all good on my end

divinetettey avatar Jun 21 '24 11:06 divinetettey