git-proxy icon indicating copy to clipboard operation
git-proxy copied to clipboard

Current config file in repo fails git-proxy --verify test

Open msagi opened this issue 1 year ago • 1 comments

Describe the bug The existing proxy.config.json file is not valid as per the config schema in the repository

To Reproduce

 % npx -- @finos/git-proxy --validate

/Users/dev/git/git-proxy/node_modules/jsonschema/lib/helpers.js:61
    throw err;
    ^
ValidationError {
  path: [],
  property: 'instance',
  message: 'is not allowed to have the additional property "tempPassword"',
  schema: 'https://git-proxy.finos.org/config.schema.json',
  instance: {
    tempPassword: { sendEmail: false, emailConfig: {} },
    authorisedList: [
      {
        project: 'finos',
        name: 'git-proxy',
        url: 'https://github.com/finos/git-proxy.git'
      }
    ],
    sink: [
      { type: 'fs', params: { filepath: './.' }, enabled: true },
      {
        type: 'mongo',
        connectionString: 'mongodb://localhost:27017/gitproxy',
        options: { useUnifiedTopology: true },
        enabled: false
      }
    ],
    authentication: [ { type: 'local', enabled: true } ]
  },
  name: 'additionalProperties',
  argument: 'tempPassword',
  stack: 'instance is not allowed to have the additional property "tempPassword"'
}

Node.js v21.7.1

Expected behavior

 % npx -- @finos/git-proxy --validate
proxy.config.json is valid

Screenshots n/a

Desktop (please complete the following information):

  • OS: macOS 14.4.1 (23E224)
  • Browser n/a
  • Version n/a

Smartphone (please complete the following information):

  • Device: n/a
  • OS: n/a
  • Browser n/a
  • Version n/a

Additional context n/a

msagi avatar Apr 01 '24 22:04 msagi

hi @JamieSlome , I can take this as a quick one

msagi avatar Apr 13 '24 00:04 msagi

fixed

msagi avatar May 05 '24 09:05 msagi