git-proxy icon indicating copy to clipboard operation
git-proxy copied to clipboard

Replace console.log with structured logging

Open coopernetes opened this issue 1 year ago • 11 comments

Git-proxy does a lot "under the hood". For operators, it would be beneficial for git-proxy to emit messages using structured logging using a library such as winston to better indicate the state of requests flowing through the system.

coopernetes avatar Jan 14 '24 17:01 coopernetes

@coopernetes - good idea. We already have the basis of log functionality on Actions and Steps. We can likely 1-for-1 swap this out with a standard library like winston.

Good idea! 👍

JamieSlome avatar Jan 15 '24 12:01 JamieSlome

Taking a look at this over the next few days 😊

LewisBroadhurst avatar Mar 04 '24 20:03 LewisBroadhurst

@LMBroadhurst - if you're interested, next Monday (and every 2 weeks) we have 1 hour meeting with all Git Proxy maintainers; if you'd like to show up and get to know each other, please email [email protected] and I'll take it from there.

Thanks for your help!

maoo avatar Mar 04 '24 21:03 maoo

@LMBroadhurst - awesome! 👍 I've assigned the ticket to you.

JamieSlome avatar Mar 04 '24 22:03 JamieSlome

Thanks @maoo would love to join. will send an email through.

LewisBroadhurst avatar Mar 09 '24 16:03 LewisBroadhurst

Hey, @LMBroadhurst I was wondering if you would like some assistance with this issue?

abinash2512 avatar Mar 28 '24 11:03 abinash2512

@LMBroadhurst - I can see you've made progress on your fork and branch. Awesome 🙌

What is outstanding?

JamieSlome avatar Mar 28 '24 12:03 JamieSlome

@abinash2512 @JamieSlome Hey guys, sorry caught a nasty bug and was wiped out the last two weeks.

I'm pretty sure the code is in place and ready to go, I just wanted to test it out by using git-proxy and was struggling a bit with it. Going to give it another go this evening to make sure the logging is working as expected.

Also was wondering, would it be useful to actually keep the console.log code, in addition to new logging?

LewisBroadhurst avatar Mar 28 '24 17:03 LewisBroadhurst

@LMBroadhurst - hope you are feeling better now - sorry to hear 😢

Let us know if you need any support in testing it; I'm generally always available ❤️

You can ping me here or on the Slack channel!

JamieSlome avatar Mar 28 '24 17:03 JamieSlome

@JamieSlome Much better now thanks 😄.

I tried to join the slack channel from the links on the repo but seems you need certain permissions to access the channels. Could you please email me an invite/add me to the slack via my email [email protected]?

LewisBroadhurst avatar Mar 28 '24 21:03 LewisBroadhurst

@JamieSlome Much better now thanks 😄.

I tried to join the slack channel from the links on the repo but seems you need certain permissions to access the channels. Could you please email me an invite/add me to the slack via my email [email protected]?

Just invited you to Slack! Ping me when you're in, so I can add you to the Git Proxy channel.

Feel free to ping [email protected] if you encounter any issues. Thanks!

maoo avatar Mar 29 '24 13:03 maoo