common-domain-model icon indicating copy to clipboard operation
common-domain-model copied to clipboard

Published 20 hours ago • verified publisher icon finos

Proposed new namespace cdm.base.staticdata.common

Open tomhealey-icma opened this issue 2 years ago • 4 comments

ISOCurrencyCodeEnum is currently located in namespace cdm.base.staticdata.asset.common but currency is not asset specific and we need to add ISO County Codes and other common ISO data. I recommend adding a new namespace, namespace cdm.base.staticdata.common for these enums.

tomhealey-icma avatar Apr 24 '23 16:04 tomhealey-icma

Agreed Currency is not specific to assets so should be extracted from that namespace. I'm not that keen on a new cdm.base.staticdata.common namespace though as I think it will end up a dumping ground for anything that does not easily fit anywhere else (and encourage people to be lazy when adding enums etc. to the model).

Would it be better to have a cdm.base.staticdata.currency or .country namespace?

chrisisla avatar Apr 25 '23 09:04 chrisisla

Hi @tomhealey-icma Can this issue be closed?

eteridvalishvili avatar Oct 30 '23 16:10 eteridvalishvili

Not yet. When we submit a PR we'll need link it to an issue.

tomhealey-icma avatar Oct 30 '23 18:10 tomhealey-icma

Hi @tomhealey-icma Was the PR submitted? Please let me know if this issue is good to close. If not, maybe we can put it on the agenda for the upcoming WGs.

eteridvalishvili avatar Mar 13 '24 20:03 eteridvalishvili