architecture-as-code icon indicating copy to clipboard operation
architecture-as-code copied to clipboard
verified publisher icon finos

103/vscodeplugin

Open Adwoa-Konadu-Appiah opened this issue 1 year ago • 3 comments

Issue 103 An initial implementation to visualize CALM instantiation when CALM: Calm Visualize Current Instantiation File is run in the VS code command pallet.

Adwoa-Konadu-Appiah avatar Oct 08 '24 11:10 Adwoa-Konadu-Appiah

Thanks for the PR @Adwoa-Konadu-Appiah!

@aidanm3341 can we get your review on this PR please.

An initial thought from me, should we place this in a top level folder called plugins then vscode that way if we create extensions for IntelliJ or other tools they can be grouped together?

rocketstack-matt avatar Oct 08 '24 19:10 rocketstack-matt

Thanks for the PR @Adwoa-Konadu-Appiah!

@aidanm3341 can we get your review on this PR please.

An initial thought from me, should we place this in a top level folder called plugins then vscode that way if we create extensions for IntelliJ or other tools they can be grouped together?

Completely agree - we should go with plugins -> vscode -> validate / visualize whatever

Thels avatar Oct 09 '24 10:10 Thels

I think we should hold fire on merging this - it looks like the calmToDot was copied into this extension folder.

There are problems having the extension depend on the CLI module, but this is something I believe we really need to overcome prior to merging.

Thels avatar Oct 09 '24 10:10 Thels

I'm going to close this PR ( along with my other PR in the similar vein ) - we can still refer to the code and can re-open once the extension framework is in place.

Thels avatar Dec 03 '24 11:12 Thels