venus icon indicating copy to clipboard operation
venus copied to clipboard

refactor: use the built-in max/min to simplify the code

Open evenevent opened this issue 8 months ago • 1 comments

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

Use the built-in max/min from the standard library in Go 1.21 to simplify the code. https://pkg.go.dev/[email protected]#max

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • [x] 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • [ ] 具有清晰明确的commit message / All commits have a clear commit message.
  • [ ] 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • [ ] 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • [ ] 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • [ ] 通过必要的检查项 / All checks are green

evenevent avatar Mar 27 '25 09:03 evenevent

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 22%. Comparing base (f8af605) to head (4aa0dc3).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6465   +/-   ##
======================================
- Coverage      22%     22%   -1%     
======================================
  Files         758     758           
  Lines       96509   96504    -5     
======================================
- Hits        22117   22103   -14     
- Misses      71518   71526    +8     
- Partials     2874    2875    +1     
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Mar 28 '25 01:03 codecov-commenter