ref-fvm icon indicating copy to clipboard operation
ref-fvm copied to clipboard

feat: wasmtime v25

Open Stebalien opened this issue 1 year ago • 3 comments

Importantly, this reverts a previous wasmtime change that enabled trace-logging in regalloc, massively slowing down compilation across all FVM versions.

fixes #2058

Stebalien avatar Oct 18 '24 15:10 Stebalien

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.72%. Comparing base (a0f85fa) to head (2d3ce72).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2059      +/-   ##
==========================================
+ Coverage   75.70%   75.72%   +0.01%     
==========================================
  Files         153      153              
  Lines       15667    15677      +10     
==========================================
+ Hits        11861    11871      +10     
  Misses       3806     3806              
Files with missing lines Coverage Δ
fvm/src/engine/mod.rs 86.57% <100.00%> (+0.28%) :arrow_up:

codecov-commenter avatar Oct 18 '24 15:10 codecov-commenter

(going to write a benchmark now to confirm that this is fixed)

Stebalien avatar Oct 18 '24 15:10 Stebalien

Benchmark in https://github.com/filecoin-project/ref-fvm/pull/2060, but I'm not seeing any compilation time changes between this version, v4.4, and v4.3.

Stebalien avatar Oct 18 '24 20:10 Stebalien