ref-fvm icon indicating copy to clipboard operation
ref-fvm copied to clipboard

Remove `verify_signature` syscall

Open Stebalien opened this issue 1 year ago • 6 comments

We now have a new verify_bls_aggregate syscall and can remove the old verify_signature syscall in the next major version.

Stebalien avatar May 08 '24 20:05 Stebalien

This needs to land after nv23

rjan90 avatar Jun 04 '24 14:06 rjan90

Specifically, this needs to land once we make the next major release of the FVM (which isn't currently planned).

Stebalien avatar Jun 04 '24 14:06 Stebalien

Note: we also need to disable this feature in the builtin actors. Once we do that, the builtin actors will no longer be using this syscall and it can be removed entirely in the next major FVM version.

Stebalien avatar Jun 04 '24 14:06 Stebalien

oh, we should do that in builtin-actors to make FIP-0079 complete, right? that should probably go on the nv23 checklist.

rvagg avatar Jun 05 '24 03:06 rvagg

Yeah, although we first need to release a new FVM version (4.3 is the safest). Then we should be able to patch the builtin-actors as follows:

diff --git a/Cargo.toml b/Cargo.toml
index e6166066..c2cca25a 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -121,8 +121,8 @@ frc42_dispatch = "5.0.0"
 frc46_token = "9.0.0"
 
 # FVM
-fvm_sdk = "~4.0"
-fvm_shared = "~4.0"
+fvm_sdk = { version = "~4.3", default-features = false }
+fvm_shared = "~4.3"
 fvm_ipld_encoding = "0.4.0"
 fvm_ipld_blockstore = "0.2.0"
 fvm_ipld_hamt = "0.8.0"

Stebalien avatar Jun 05 '24 22:06 Stebalien

ok, let's wait to get the new ni-porep proofs in and then do a 4.3

rvagg avatar Jun 06 '24 00:06 rvagg