ref-fvm icon indicating copy to clipboard operation
ref-fvm copied to clipboard

feat: FIP-0079: syscall for aggregated bls verification

Open hanabi1224 opened this issue 1 year ago • 1 comments

This PR tries to implement https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0079.md without breaking FVM backward compatibility.

(NOTE: This PR is largely based on https://github.com/filecoin-project/ref-fvm/pull/1914)

Closes https://github.com/filecoin-project/ref-fvm/issues/2001

Changes:

  • Add verify_bls_aggregate syscall
  • Add cargo feature verify-signature that keeps verify_signature syscall for backward compatibility
  • Add integration test for the verify-signature feature
  • Update CI to build and check the verify-signature feature

hanabi1224 avatar Apr 29 '24 09:04 hanabi1224

@DrPeterVanNostrand could you please help taking a look at this PR?

jennijuju avatar May 02 '24 12:05 jennijuju

Codecov Report

Attention: Patch coverage is 85.71429% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 57.04%. Comparing base (c39d880) to head (169d615).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2003       +/-   ##
===========================================
- Coverage   75.62%   57.04%   -18.58%     
===========================================
  Files         157      119       -38     
  Lines       15750    10381     -5369     
===========================================
- Hits        11911     5922     -5989     
- Misses       3839     4459      +620     
Files Coverage Δ
fvm/src/gas/price_list.rs 74.65% <100.00%> (-3.66%) :arrow_down:
fvm/src/syscalls/crypto.rs 100.00% <100.00%> (ø)
fvm/src/syscalls/mod.rs 97.14% <100.00%> (+0.06%) :arrow_up:
shared/src/crypto/signature.rs 53.84% <83.33%> (-9.76%) :arrow_down:
fvm/src/syscalls/context.rs 93.97% <72.22%> (-6.03%) :arrow_down:
fvm/src/kernel/default.rs 82.13% <76.66%> (-0.20%) :arrow_down:

... and 93 files with indirect coverage changes

codecov-commenter avatar May 07 '24 01:05 codecov-commenter