ref-fvm icon indicating copy to clipboard operation
ref-fvm copied to clipboard

Implement FIP-0079 with Backwards Compatibility

Open rjan90 opened this issue 1 year ago • 2 comments

Description

FIP-0079, which has been accepted, introduces a syscall for BLS aggregate signatures. It has a PR open in https://github.com/filecoin-project/ref-fvm/pull/1914, but it has not been merged due to concerns about requiring a major FVM version update.

After some discussion we have leaned towards merging this feature under a feature flag to avoid the need of a major version update. This approach would allow the inclusion of the FIP in the upcoming network upgrade without waiting for other significant changes that necessitate a new FVM version.

Task

The current PR is outdated and has a lot of conflicts. We need to created a new branch and copy the PR changes in, make it backwards compatible and add it behind a feature flag.

References

rjan90 avatar Apr 19 '24 00:04 rjan90

Basically:

  1. We can make breaking changes to the SDK, as long as we bump the minor version.
  2. We can't remove the current verify_signature syscall.
  3. We can add and use the new verify_bls_aggregate syscall.

So, TODO: Bring back the verify_signature syscall behind an enabled-by-default feature. E.g. IPC can disable it.

Stebalien avatar Apr 19 '24 00:04 Stebalien

👍 it's good not to break things if we don't really need to, especially if it means shipping features that users are asking for 🚢

rvagg avatar Apr 19 '24 01:04 rvagg

This requires an update to FIP-0079 to remove the references to verify_signature, correct?

rvagg avatar May 06 '24 01:05 rvagg

This requires an update to FIP-0079 to remove the references to verify_signature, correct?

IMO, no. From the perspective of the network, verify_signature will go away. Technically the ref-fvm will expose it as an available syscall, but the builtin actors won't use it (and user deployed actors aren't possible).

Stebalien avatar May 09 '24 18:05 Stebalien