ref-fvm icon indicating copy to clipboard operation
ref-fvm copied to clipboard

Published 20 hours ago • verified publisher icon filecoin-project

Non Interactive Proof of Replication

Open NemanjaLu92 opened this issue 1 year ago • 5 comments

NemanjaLu92 avatar Apr 13 '24 20:04 NemanjaLu92

This is probably ready for review. We'll need it to land so the actors change can depend on it.

@Stebalien the associated FIP is accepted. Can we land this direct to master?

anorth avatar May 10 '24 01:05 anorth

It looks like this doesn't build with the "proofs" feature enabled.

Stebalien avatar May 10 '24 04:05 Stebalien

just needs the additional TryFrom matches added I believe

rvagg avatar May 13 '24 06:05 rvagg

just needs the additional TryFrom matches added I believe

True, but I need to change dependancy to the filecoin-proofs-api which doesn't include NI PoRep Registered proof in latest version (17.0). How should we proceed? Create a new release in filecoin-proofs-api and update dependency in ref-fvm?

NemanjaLu92 avatar May 16 '24 00:05 NemanjaLu92

True, but I need to change dependancy to the filecoin-proofs-api which doesn't include NI PoRep Registered proof in latest version (17.0). How should we proceed? Create a new release in filecoin-proofs-api and update dependency in ref-fvm?

A new Filecoin-proofs-api release is expected to be out today (Thursday May 16th), which includes the NI-PoRep registered proofs.

rjan90 avatar May 16 '24 07:05 rjan90

It looks like storage-proofs-update is either missing a minimum version specification for something, or it isn't enabling some feature flag... @cryptonemo?

Stebalien avatar May 22 '24 21:05 Stebalien

Can we close this, since its superseded by https://github.com/filecoin-project/ref-fvm/pull/2010?

rjan90 avatar Jun 11 '24 12:06 rjan90

Yes.

Stebalien avatar Jun 11 '24 14:06 Stebalien