ref-fvm icon indicating copy to clipboard operation
ref-fvm copied to clipboard

EVM Tests: Change rt.expect_send_generalized ErrorNumber handling

Open Stebalien opened this issue 2 years ago • 0 comments

It currently accepts:

    pub fn expect_send_generalized(
        &mut self,
        to: Address,
        method: MethodNum,
        params: Option<IpldBlock>,
        value: TokenAmount,
        gas_limit: Option<u64>,
        send_flags: SendFlags,
        send_return: Option<IpldBlock>,
        exit_code: ExitCode,
        send_error: Option<ErrorNumber>,
    ) {

We should consider changing this to:

    pub fn expect_send_generalized(
        &mut self,
        to: Address,
        method: MethodNum,
        params: Option<IpldBlock>,
        value: TokenAmount,
        gas_limit: Option<u64>,
        send_flags: SendFlags,
        outcome: Result<Response, ErrorNumber>, // <--
    ) {

Stebalien avatar Jan 25 '23 07:01 Stebalien