lotus icon indicating copy to clipboard operation
lotus copied to clipboard

fix: cli: Adjust default value for sectors extend's --extension flag

Open dd45e640b42e6da7da96faee3996ef7c opened this issue 1 year ago • 6 comments

set default value to new, post nv21, max. lifetime - 3680640

fixes: https://github.com/filecoin-project/lotus/issues/11575

see: https://filecoinproject.slack.com/archives/CP50PPW2X/p1705229863466399

Checklist

Before you mark the PR ready for review, please make sure that:

  • [x] Commits have a clear commit message.
  • [ ] PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • [ ] If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • [ ] New features have usage guidelines and / or documentation updates in
  • [ ] Tests exist for new functionality or change in behavior
  • [ ] CI is green

Looks good to me! Though I suspect some of the checks will not pass, as both make gen and make docsgen would be needed in this case to genereate extra assets/update the CLI docs

rjan90 avatar Jan 14 '24 11:01 rjan90

i am not into the ci running to make this a clean PR - let em know if something needs to be adjusted elsewhere to have this considered

i am not into the ci running to make this a clean PR - let em know if something needs to be adjusted elsewhere to have this considered

Looks like the gen-check is still mad. You can run the make gen script when being in the /lotus-folder:

cd lotus
make gen
make docsgen-cli

Let me know if you are able to execute the script, else I can run it here and push that change.

rjan90 avatar Jan 14 '24 11:01 rjan90

i edit this on github directly due to how little the changes actually are

i edit this on github directly due to how little the changes actually are

I understand. But the CI gen-check compares the CLI-docs with CLI cmd/code. And if there is a divergence, it will fail.

I can run the docsgen, and push the change, if you give me the 🟢

rjan90 avatar Jan 15 '24 08:01 rjan90

sure, do what you need to do ;)