docs icon indicating copy to clipboard operation
docs copied to clipboard

Fixing docker example command for latest alpine image

Open psolru opened this issue 3 years ago • 7 comments
trafficstars

While checking out filebrowser, I just noticed the database file is in the latest version of the alpine image in the same location as for the non-alpine image.
/database/filebrowser.db

This simply adjusts the example docker run command of the install docs

psolru avatar May 16 '22 11:05 psolru

I just got stumped by this. Would be nice to have the PR merged to update the docs.

slinkytoad avatar May 30 '23 19:05 slinkytoad

That is not correct. The default config file for docker points to the /filebrowser.db

o1egl avatar Jul 22 '23 19:07 o1egl

That is not correct. The default config file for docker points to the /filebrowser.db

The default config points to filebrowser.db but the docker command maps a file on the local filesystem called filebrowser.db to one on the docker container's file system called database.db

To fix this we can either update the default config to expect a file called "database.db" or do what this PR suggested and update the docker command so that a file called "filebrowser.db" appears on the container file system

For what its worth, my install on docker did not work out of the box and these fixes were required.

HackintoshwithUbuntu avatar Dec 02 '23 00:12 HackintoshwithUbuntu

That is not correct. The default config file for docker points to the /filebrowser.db

The default config points to filebrowser.db but the docker command maps a file on the local filesystem called filebrowser.db to one on the docker container's file system called database.db

To fix this we can either update the default config to expect a file called "database.db" or do what this PR suggested and update the docker command so that a file called "filebrowser.db" appears on the container file system

For what its worth, my install on docker did not work out of the box and these fixes were required.

I'm not sure I'm following you. This is the default database path https://github.com/filebrowser/filebrowser/blob/master/docker_config.json#L6C30-L6C30

o1egl avatar Dec 06 '23 10:12 o1egl

I'm not sure I'm following you. This is the default database path https://github.com/filebrowser/filebrowser/blob/master/docker_config.json#L6C30-L6C30

I think the confusion is arising because we are referencing two different files.

  1. I was talking about https://github.com/filebrowser/filebrowser/blob/master/docker/root/defaults/settings.json which is listed on the official installation guide here
  2. In the previous comment you have linked https://github.com/filebrowser/filebrowser/blob/master/docker_config.json

I think you would probably have a more in-depth knowledge than me about which file is actually being used

HackintoshwithUbuntu avatar Dec 07 '23 04:12 HackintoshwithUbuntu

I'm not sure I'm following you. This is the default database path https://github.com/filebrowser/filebrowser/blob/master/docker_config.json#L6C30-L6C30

I think the confusion is arising because we are referencing two different files.

  1. I was talking about https://github.com/filebrowser/filebrowser/blob/master/docker/root/defaults/settings.json which is listed on the official installation guide here
  2. In the previous comment you have linked https://github.com/filebrowser/filebrowser/blob/master/docker_config.json

I think you would probably have a more in-depth knowledge than me about which file is actually being used

You are referrencing a linuxserver based image config, but actually changing a regular docker file. It uses docker_config.json which points to the /database.db

o1egl avatar Dec 28 '23 09:12 o1egl

I'm not sure I'm following you. This is the default database path https://github.com/filebrowser/filebrowser/blob/master/docker_config.json#L6C30-L6C30

I think the confusion is arising because we are referencing two different files.

  1. I was talking about https://github.com/filebrowser/filebrowser/blob/master/docker/root/defaults/settings.json which is listed on the official installation guide here
  2. In the previous comment you have linked https://github.com/filebrowser/filebrowser/blob/master/docker_config.json

I think you would probably have a more in-depth knowledge than me about which file is actually being used

You are referrencing a linuxserver based image config, but actually changing a regular docker file. It uses docker_config.json which points to the /database.db

My apologies, I understand now. Thanks for the clarification.

HackintoshwithUbuntu avatar Dec 28 '23 10:12 HackintoshwithUbuntu