vite-plugin-checker
vite-plugin-checker copied to clipboard
fi3ework
feat: add basic support for Biome
Fixes #279
Mostly based on the ESLint checker.
I can add examples later.
I tried to create an example in StackBlitz but Biome doesn't work in StackBlitz for now.
🦋 Changeset detected
Latest commit: a06f0dfdca17b31e3bdd7df5b388301c9672b6dd
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| vite-plugin-checker | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for vite-plugin-checker ready!
| Name | Link |
|---|---|
| Latest commit | a06f0dfdca17b31e3bdd7df5b388301c9672b6dd |
| Latest deploy log | https://app.netlify.com/sites/vite-plugin-checker/deploys/668c55f1c531fd0008f3c412 |
| Deploy Preview | https://deploy-preview-316--vite-plugin-checker.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
This is all that's holding us back from adopting Biome ATM. When will you merge this?
@fi3ework , any chance to merge this, maybe with an experimental _unstable prefix until there is more feedback?
As this is not getting merged, I am going to create a temporary fork and merge this there. I want to get out of ESlint ecosystem soon and this is blocking me.
Edit: My fork is ready and can be installed as vite-plugin-checker-biome
@KurtGokhan the failed tests, was it just a faulty run or is it broken in those scenarios? asking mostly because of node-20 ubuntu
@KurtGokhan the failed tests, was it just a faulty run or is it broken in those scenarios? asking mostly because of node-20 ubuntu
@kamikazePT Tests are faulty for quite some time - see https://github.com/fi3ework/vite-plugin-checker/issues/264. Seems like they are getting fixed in PR https://github.com/fi3ework/vite-plugin-checker/pull/327.
Thanks @KurtGokhan for your contributing, and sorry for the long time to respond. I tweaked the code and it almost done. While there's something wrong when updating file diagnostic on Windows (I guess that's caused by the mix use of absPath and Biome's file.path. Could you help out if you're using a Window machine, or I'll take some time to grab a Windows machine next week. Thanks.
@fi3ework Thanks a lot for the updates. It looks much more polished now.
I noticed the issue now. Will try to fix it.
The issue should be fixed now.
Although now I think, it would be easier to just re-run Biome on all files on every file change, and it wouldn't even be noticeable because Biome is so fast. Maybe can add it as an option later.
The issue should be fixed now. Although now I think, it would be easier to just re-run Biome on all files on every file change, and it wouldn't even be noticeable because Biome is so fast. Maybe can add it as an option later.
If we could make it incremental and scalable now, we'd keep in this way. Full re-scan will take up all CPU resources (I guess, Biome will try to use the utmost resource it could), and that could cause a lag in user's device.