vite-plugin-checker icon indicating copy to clipboard operation
vite-plugin-checker copied to clipboard

test: update win32 test serializer to work on any win32 machine

Open armano2 opened this issue 1 year ago • 2 comments

This Pr fixes snapshot testing on windows machines that are not CI

armano2 avatar Apr 06 '24 12:04 armano2

⚠️ No Changeset found

Latest commit: 2d869a0150455cf07b95c948f2d080a17771136c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 06 '24 12:04 changeset-bot[bot]

Deploy Preview for vite-plugin-checker ready!

Name Link
Latest commit 2d869a0150455cf07b95c948f2d080a17771136c
Latest deploy log https://app.netlify.com/sites/vite-plugin-checker/deploys/667fe252797a1e000837fbf2
Deploy Preview https://deploy-preview-313--vite-plugin-checker.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 06 '24 12:04 netlify[bot]

if you want we could just replace jest-serializer-path with simpler serializer

armano2 avatar Jun 29 '24 09:06 armano2

If we could makes it work with a simple, promising script, we definitely could remove jest-serializer-path.

fi3ework avatar Jun 29 '24 09:06 fi3ework

do you want me to update this PR, or submit it as separate one?

armano2 avatar Jun 29 '24 10:06 armano2

updating this PR is fine.

fi3ework avatar Jun 29 '24 10:06 fi3ework

Looks like something like this is going to work

armano2 avatar Jun 29 '24 10:06 armano2

Thank you! I'm AFK now, will take a look into the code when back later today.

fi3ework avatar Jun 29 '24 10:06 fi3ework