vite-plugin-checker icon indicating copy to clipboard operation
vite-plugin-checker copied to clipboard

add support for vue-tsc 2.0.1

Open simensfo opened this issue 1 year ago • 5 comments

resolves #306

simensfo avatar Mar 06 '24 11:03 simensfo

⚠️ No Changeset found

Latest commit: 7d54d44fcfed05c81de36b2e78eb5f0a64aa4e26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Mar 06 '24 11:03 changeset-bot[bot]

Deploy Preview for vite-plugin-checker ready!

Name Link
Latest commit 7d54d44fcfed05c81de36b2e78eb5f0a64aa4e26
Latest deploy log https://app.netlify.com/sites/vite-plugin-checker/deploys/65e8555faab586000805f7fb
Deploy Preview https://deploy-preview-307--vite-plugin-checker.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 06 '24 11:03 netlify[bot]

it's not easy to solve the issue by this way, vue-tsc 2 changed a lot. We need to figure out a new way to integrate with it.

fi3ework avatar Mar 06 '24 12:03 fi3ework

I may be wrong, but based on the changelog there aren't really any breaking changes. If this plugin mostly just runs vue-tsc during build, then wouldn't it be enough to just import from the right place?

simensfo avatar Mar 06 '24 12:03 simensfo

build part should be working fine even without this change, issue is with what is done during "patching" of lib

i was generally thinking about this, and wdyt about using tsserver instead? https://github.com/microsoft/TypeScript/wiki/Standalone-Server-(tsserver)

this patching for both typescript and vue seem to be an kinda an overkill

armano2 avatar Apr 01 '24 00:04 armano2