foleys_video_engine icon indicating copy to clipboard operation
foleys_video_engine copied to clipboard

Foleys Video Engine does not support JUCE 7

Open jrlanglois opened this issue 3 years ago • 2 comments

Specifically, juce::AudioPlayHead has had its positional information method API changed entirely, thus breaking AudioProcessorAdapter::PlayHead.

getCurrentPosition should be changed to getPosition, which means you'll have to pick either seconds or samples as basis for time.

jrlanglois avatar Jun 22 '22 19:06 jrlanglois

The new API is intended to support all of the use-cases supported by the old API. The PositionInfo instance returned from getPosition can contain both a time-in-seconds and a time-in-samples. Just call PositionInfo::setTimeInSeconds and PositionInfo::setTimeInSamples on the instance that you return.

reuk avatar Jun 23 '22 13:06 reuk

Thanks for the heads up! I think it's best to freeze the current state in a juce6 branch and fix it in develop

ffAudio avatar Jun 24 '22 16:06 ffAudio