ff4j icon indicating copy to clipboard operation
ff4j copied to clipboard

Showing an alert message while toggling any feature & Removing FF4J_TABLES if not used by the application.

Open parul7802 opened this issue 5 years ago • 4 comments
trafficstars

@clun I am using FF4J for implementing Feature Toggle for my Team's application.

While working on it I found some features we can add to make it more user friendly & have few questions as well.

  • While using it I found that it would be useful to have an alert kind of box which kind of asks us 'Are we sure we want to enable/disable this toggle ? ' while we are toggling the feature. I believe this would be useful because if it's a Release Toggle & we have unintentionally/in haste enabled it , it might for a couple of seconds make the production environment unstable leading to inconvenience of end users.

  • So far we don't have need for FF4J_ROLES Table as it will be strictly used by admin only & we are integrating an another admin page for the admin authentication . I want to know is there a way, this table can be deleted ? FYI I'm using the below configuration. FF4JBean

parul7802 avatar Oct 08 '20 13:10 parul7802

I second :) We plan to use FF4J to toggle on-off and/or A/B test features in video games played by a large number of players. It would be very nice to force confirmation of feature state changes to avoid accidentally turning features on or off and the associated impact on game play experience for a large player base.

paskos avatar Oct 19 '20 17:10 paskos

I agree.

I would add a more generic behaviour here.

I will add a Map<String, String> at ff4j class level where you can ADD keys (not enforcing keys with enum to allow you add what you need. I would need to update the settings screen)

ff4j.getCustomKeys().put("WHEN_TOGGLING_FEATURE_ASK_FOR_CONFIRMATION", true);
ff4j.getCustomKeys().put("WHEN_TOGGLING_FEATURE_PROVIDE_COMMENT", true);
ff4j.getCustomKeys().put("WHEN_DELETING_FEATURE_ASK_FOR_CONFIRMATION", true);
ff4j.getCustomKeys().put("WHEN_DELETING_PROPERTY_ASK_FOR_CONFIRMATION", true);

clun avatar Oct 30 '20 09:10 clun

At framework level we cannot easily remove the ROLES_TABLE as it is used a lot in JdbcFeatureStore for both read and write. Even if you don't define ROLE yourself you can allow a population of user to use your very own feature.

Nevertheless to drop this table you would have to extend the class JdbcFeatureStore and change the code where is it used. As it is localized in a single class this is doable and this class does not really change for a few releases now.

clun avatar Oct 30 '20 09:10 clun

Yep agreed @paskos . Thanks @clun

parul7802 avatar Dec 29 '20 18:12 parul7802