FESTIM icon indicating copy to clipboard operation
FESTIM copied to clipboard

Additional derived quantities

Open RemDelaporteMathurin opened this issue 2 years ago • 2 comments

  • [ ] TotalVolume
    • [x] Cartesian #703
    • [ ] Cylindrical
    • [ ] Spherical
  • [ ] AverageVolume
    • [ ] Cartesian
    • [ ] Cylindrical
    • [ ] Spherical
  • [ ] TotalSurface
    • [ ] Cartesian
    • [ ] Cylindrical
    • [ ] Spherical
  • [ ] AverageSurface
    • [ ] Cartesian
    • [ ] Cylindrical
    • [ ] Spherical
  • [ ] MinimumVolume
  • [ ] MaximumVolume
  • [ ] MinimumSurface
  • [ ] MaximumSurface

RemDelaporteMathurin avatar Nov 13 '23 12:11 RemDelaporteMathurin

I just started working on this issue, is there any specificities to keep in mind while doing it ?

JonathanGSDUFOUR avatar Mar 06 '24 13:03 JonathanGSDUFOUR

I just started working on this issue, is there any specificities to keep in mind while doing it ?

Glad to hear! So I've opened a PR for TotalVolume #703 since I needed it for one of my branches but the rest is still left to do. Maybe one difference with FESTIM 1 is that we would like derived quantities to be "stand alone".

In FESTIM-1 all the DerivedQuantity objects have to be bundled in a DerivedQuantities object, and this bigger object has a filename attribute to export to csv.

In FESTIM2, we would like to be able to export each DerivedQuantity independently which means they all have a filename attribute.

Later down the line, we'll think of how we can also bundle them to avoid having too many files, but I think this new architecture will be easier to deal with and more flexible.

Apart from that, I'm not aware of any specificity. I remember that finding the minimum and maximum of a solution in a subdomain in legacy-fenics was a bit tricky, I don't know how to do it in dolfinx. The fenics discourse group is your friend! 😄

RemDelaporteMathurin avatar Mar 06 '24 13:03 RemDelaporteMathurin