simple-peer
simple-peer copied to clipboard
fix: migrate to streamx
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update [ ] Bug fix [ ] New feature [x] Other, please explain:
What changes did you make? (Give an overview) Migrated to streamx Which issue (if any) does this pull request address? https://github.com/webtorrent/webtorrent/issues/1971 Is there anything you'd like reviewers to focus on? Tests.
Previously this forced Buffer, now it's... whatever the browser yields. This causes 2 tests to fail.
Node readable state's are different from streamx's readable states. This causes 4 tests to fail, as I likely edited the code for these changes and tests incorrectly, I'm not certain how to handle this.
Out of curiosity, what is the benefit of this migration to streamx?
Edit: Disregard, I see the discussion: https://github.com/webtorrent/webtorrent/issues/1971
@feross any concerns about merging this?
@feross any concerns about merging this?
yes, it's broken as streamx handles stream states differently, and I don't know how to fix it, there are like 11 other PR's in the webtorrent ecosystem before this one which are actually working
New dependency changes detected. Learn more about Socket for GitHub ↗︎
👍 No new dependency issues detected in pull request
Bot Commands
To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all
Pull request alert summary
| Issue | Status |
|---|---|
| Install scripts | ✅ 0 issues |
| Native code | ✅ 0 issues |
| Bin script shell injection | ✅ 0 issues |
| Unresolved require | ✅ 0 issues |
| Invalid package.json | ✅ 0 issues |
| HTTP dependency | ✅ 0 issues |
| Git dependency | ✅ 0 issues |
| Potential typo squat | ✅ 0 issues |
| Known Malware | ✅ 0 issues |
| Telemetry | ✅ 0 issues |
| Protestware/Troll package | ✅ 0 issues |
| AI detected security risk | ✅ 0 issues |
| AI warning | ✅ 0 issues |
📊 Modified Dependency Overview:
| ➕ Added Package | Capability Access | +/- Transitive Count |
Publisher |
|---|---|---|---|
| [email protected] | None | +2 |
mafintosh |