wasi-experimental-toolkit icon indicating copy to clipboard operation
wasi-experimental-toolkit copied to clipboard

Error handling in tests is not clear

Open radu-matei opened this issue 3 years ago • 3 comments
trafficstars

The current way errors are handled in tests is not at all clear. Theoretically, test implementations could return an error, but the test runtime ignores the errors, even when unwrapped.

This could (?) be an issue in the way the Wasmtime import bindings handle expected<_, error>.

radu-matei avatar Dec 03 '21 23:12 radu-matei

@radu-matei do we care still? Who should give us a path forward?

squillace avatar Feb 03 '22 10:02 squillace

We still care, someone has to go through the test setup process and make sure errors are not silently swallowed at some point.

radu-matei avatar Feb 03 '22 11:02 radu-matei

@radu-matei Theoretically, test implementations could return an error, but the test runtime ignores the errors, even when unwrapped.

The cause is probably what I fixed in #18?

Porges avatar Feb 16 '22 21:02 Porges