SwiftUIPager icon indicating copy to clipboard operation
SwiftUIPager copied to clipboard

[BUG] Pager scrolls in the opposite direction in RLT languages

Open larryonoff opened this issue 1 year ago • 6 comments

Describe the bug Pager scrolls in the opposite direction in RLT languages. User tries to scroll from top-to-bottom, but pager scrolls from bottom-to-top.

To Reproduce

    GeometryReader { geometry in
      let itemSize = CGSize(
        width: geometry.size.width,
        height: geometry.size.height - 63
      )

      if !itemSize.isEmpty {
        Pager(
          page: page,
          data: viewStore.state,
          id: \.self,
          content: { element in
            ...
          }
        )
        .alignment(.start)
        .itemSpacing(.itemSpacing)
        .preferredItemSize(itemSize, alignment: .start)
        .sensitivity(.high)
        .vertical()
        .templatePreviewSize(itemSize)
     }
  }

Expected behavior Pager scrolls in the same direction user scrolls.

Environment:

  • iOS: 15, 16, 17
  • Device: Any iPhone
  • SwiftUIPager version: 2.5.0

larryonoff avatar Jan 31 '24 16:01 larryonoff

Same Problem with scrolling for RTL languages is also for harizontal pager

zoltanbognar avatar Jan 14 '25 13:01 zoltanbognar

@zoltanbognar I have fix https://github.com/fermoya/SwiftUIPager/pull/335

larryonoff avatar Jan 14 '25 14:01 larryonoff

@larryonoff This is great . when do you think it will be available in main branch with version release? Thanks a lot

zoltanbognar avatar Jan 19 '25 17:01 zoltanbognar

@zoltanbognar looks that never. PR is 1 year old.

larryonoff avatar Jan 19 '25 18:01 larryonoff

@larryonoff @fermoya who should be notified to handle the merge and new version ? sorry i'm not familiar how this process in git lab works Thanks a lot

zoltanbognar avatar Jan 22 '25 13:01 zoltanbognar

@zoltanbognar I'm not a maintainer of this project. Just made a PR

larryonoff avatar Jan 22 '25 14:01 larryonoff