php-language-server icon indicating copy to clipboard operation
php-language-server copied to clipboard

Linux Path Recognition is Broken

Open sbani opened this issue 6 years ago • 0 comments
trafficstars

Hi,

i found a bug in linux when using a samba share.

The code in uriToPath and pathToUri is not prepared to handle linux shares.

My share path is file:///run/user/1000/gvfs/smb-share:server=127.0.0.1,share=mrfoo/bar/composer.php which is not a windows path. But the code is only checking for the :character and thinks it is a windows path.

I tried to fix it, but I'm not sure about a good way to fix this issue: First, I would say that the path should know about it's current OS. Everything can be handled easier, but it's not generic anymore.

Second, fixing the generic version and staying generic, is not as easy as I thought. I'll have to change more code.

Before I try to fix it myself, I would appreciate some input from one of the maintainers. Just to make sure I'm on the right path.

Thank you for your effort and regards

sbani avatar May 17 '19 13:05 sbani