fedimint-web-sdk icon indicating copy to clipboard operation
fedimint-web-sdk copied to clipboard

Add `parseInivteCode` function to the core library

Open alexlwn123 opened this issue 1 year ago • 6 comments

We want to be able to extract a federationId from an inviteCode without needing to join a federation.

The rust client already has a parseInviteCode function. We just need to expose the function as an RPC in the wasm.

alexlwn123 avatar Oct 22 '24 09:10 alexlwn123

@alexlwn123 I would like to work on this, Could you please assign it to me?

MrImmortal09 avatar Mar 15 '25 09:03 MrImmortal09

@MrImmortal09 Do you understand what needs to be done? This involves making Rust changes in the fedimint/fedimint repo and updating the corresponding wasm bundles.

alexlwn123 avatar Mar 16 '25 22:03 alexlwn123

I’d love to give this a try and contribute. Would you be open to letting me attempt it? I’ll take feedback and improve accordingly.

MrImmortal09 avatar Mar 17 '25 04:03 MrImmortal09

I have opened a PR in the fedimint/fedimint repo updating the changes required.

It would be great if you could review that.

MrImmortal09 avatar Mar 18 '25 15:03 MrImmortal09

Hey @alexlwn123 , since #7046 is merged, do I need to make a PR to update Packages/wasm-web and Packages/wasm-bundler?

MrImmortal09 avatar Mar 19 '25 12:03 MrImmortal09

Hey @alexlwn123 , since https://github.com/fedimint/fedimint/pull/7046 is merged, do I need to make a PR to update Packages/wasm-web and Packages/wasm-bundler?

Congrats, @MrImmortal09!! That's awesome. 🚀🚀🚀

Yep! Feel free to keep going. To complete this issue issue, we'll need to:

  1. Use wasm-pack to build fedimint-client-wasm with target web and target bundler.
  2. Update the corresponding packages here in the fedimint-web-sdk repo. (packages/wasm-bundler for bundler & packages/wasm-web for web). Make sure you include a changeset on the pr.
  3. Implement the parseInivteCode function in the FederationService.

alexlwn123 avatar Mar 20 '25 19:03 alexlwn123

closed per https://github.com/fedimint/fedimint-web-sdk/pull/128

alexlwn123 avatar Jun 04 '25 02:06 alexlwn123