fedimint-web-sdk icon indicating copy to clipboard operation
fedimint-web-sdk copied to clipboard

feat: Implemented pegin and pegout methods

Open Harshdev098 opened this issue 6 months ago • 3 comments

Implemented Pegin and Pegout methods in wallet service

Harshdev098 avatar May 23 '25 21:05 Harshdev098

🦋 Changeset detected

Latest commit: 1db4899d3fdc427e5f1a3ad4851e0b82aff53fad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@fedimint/core-web Patch
@fedimint/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 23 '25 21:05 changeset-bot[bot]

@alexlwn123 Can you please review it!

Harshdev098 avatar May 23 '25 21:05 Harshdev098

Hey @alexlwn123 Added test for pegout but its giving validation error can you share any more context about this like why its happening!

Harshdev098 avatar May 27 '25 08:05 Harshdev098

@alexlwn123 Updated the PR, its working now in wallet!

Harshdev098 avatar Jun 04 '25 13:06 Harshdev098

any ideas why the test is failing?

alexlwn123 avatar Jun 09 '25 16:06 alexlwn123

Don't know its working as expected, I can't run the test locally because of system requirements 😔

image

Harshdev098 avatar Jun 09 '25 17:06 Harshdev098

Okay, so I've fixed the tests. Seems to be working well locally, but it looks like the generateAddress rpc is flakey. Every once and a while it just hangs. Any ideas @Harshdev098 @maan2003? Super strange.

run where it hangs: here run where it passes: here

Passing image
Failing image

alexlwn123 avatar Jul 01 '25 22:07 alexlwn123

merging because mostly looks good and we can fix stuff in follow ups.

goal is to get a canary release.

maan2003 avatar Jul 30 '25 07:07 maan2003