feathers-sequelize
feathers-sequelize copied to clipboard
Dove Support
- [x] Tell us about the problem your pull request is solving.
Updates
@feathersjsdependencies to^5.0.0-pre.3to work with Dove - [x] Are there any open issues that are related to this? Not that I could find
- [x] Is this PR dependent on PRs in other repos? Nope!
This pull request primarily updates the type expectations to match Dove. It would obviously be better for this to remain it's own branch and did not merge with master, but there is not currently a Dove branch.
All tests pass with npm test
Great, thank you for doing that! I'm wondering if I should move the Paginated type back into the main repo if that is the only breaking change (which it looks like it is).
I'm happy to pull the changes in if you do. Out of curiosity, what was the reason for moving it in the first place?
Well, the type isn't really something a core Feathers service expects or uses, it's only a convention used by the adapters. I just published 5.0.0-pre.4 changing it back. I think most things should now be backwards compatible but it'd probably be good to pass the new generic types along so you can initialize the adapter service with data and return types other than any.
I've bumped everything to 5.0.0-pre.4 and moved the Paginated import back. All tests are still passing.
I've bumped everything to 5.0.0-pre.9, and all tests are still passing.
This is good to know. At least updating the adapters (other than infrastructure) should be doable then. I had to make a bunch of dud pre-releases because the publish was broken so I didn't expect too much to change.
I've bumped everything to 5.0.0-pre.16, and all tests are still passing.
merged via #400 into master. [email protected] released with dove support.
Thanks for kicking this off!