feathers-hooks-common

feathers-hooks-common copied to clipboard

New Hooks: variableMulti and variableWhitelist

6

Database adapters offer us options to control `multi` and `whitelist`, but they do not provide us a way to change these options per some variable. For example, we may want...

DaddyWarbucks

keepQuery does not keep '$' query fields

1

### Steps to reproduce `[keepQuery('field'), disablePagination()]` does not work since `keepQuery` removes `$limit` ### Expected behavior `keepQuery` should either keep dollar query fields or a new hook should be provided.

stellarhoof

Cache hit/miss should be visible in hook context

2

I might just not be able to find it, but I think that in a hook, there is no way to check if results come from the cache or not?...

tvld

The two new hooks: `capitalize` and `trim` work like [loweCase](https://hooks-common.feathersjs.com/hooks.html#lowercase).

fratzinger

fastJoin Error

3

Version: 5.0.6 with feathers version 4.5.11 I'm working with fastJoin and for some reason unable to get it to work. Code: ```javascript const postResolvers = { joins: { conf: (...args)...

Ryan8765

Reconsider deprecation of `disable-multi-item-change`

1

The deprecation notice [suggests usage of `multi: true` option](https://hooks-common.feathersjs.com/migrating.html#deprecations), but the problem is `multi: true` has no flexibility at all and sets the behavior for both internal and external calls...

1valdis

Typescript: Hook type no longer compatible for disablePagination

3

### Steps to reproduce Using disablePagination hook produces a typescript error eg. 1 ```js // /src/app.hooks.ts import { disablePagination } from "feathers-hooks-common"; export default { before: { all: [], find:...

lwhiteley

Why fastJoin is preferred over using populate?

1

This sentence is repeated on both hooks related documentation sections: - https://hooks-common.feathersjs.com/hooks.html#fastjoin - https://hooks-common.feathersjs.com/hooks.html#populate > fastJoin is preferred over using populate But I didn't find any link or explanation about...

soullivaneuh

softDelete() provider should not inherit from original params

2

https://github.com/feathersjs-ecosystem/feathers-hooks-common/blob/f91393d839e0f155ccf15f7e7d5f6e1b35977015/lib/services/soft-delete.js#L37 So in the `softDelete` function the `params.provider` is inherited from the original method (remove), but it should be an internal call like it was in ~~previous versions~~ ([feathers-plus](https://feathers-plus.github.io/v1/feathers-hooks-common/#softdelete2)) of...

rodeyseijkens

The documentation site shows [the example for the discardQuery hook](https://hooks-common.feathersjs.com/hooks.html#discardquery) in the after hooks however it only makes sense as a before hook and is listed as not allowed in...

fontzter