feathers-elasticsearch
feathers-elasticsearch copied to clipboard
Updates to work with dove
Summary
This PR is a starter for updating adapter to work with v5 Dove as well as update to using newest version of Elastic Search mention in #113
I made some adjustments to folder structure to bring in line with core adapters of Dove.
Other Information
I would not consider this a complete PR. I have not spent time fixing the tests suite or updating current type definitions as adapter should probably be fully converted to TS since thats the direction v5 chose. Opening this PR as a starter boilerplate for anyone else working with Dove Betas
Thank you for putting that together! Does this also cover the same things as the work done in the https://github.com/feathersjs-ecosystem/feathers-elasticsearch/tree/elasticsearch-7 branch?
@daffl I didn't look at that branch previously. At a quick glance it looks like theres some differences in adding body In the returns in the elasticsearch-7 branch. I did upgrade to the newest @elastic/elasticsearch but I didn't actually need to change much else down though the methods except for a few tweaks here and there. I did make some changes for how params were passed to the methods, like ability to set routingKey through query. If the goal of elasticsearch-7 was to move from the deprecated elasticsearch to @elastic/elasticsearch then my branch does cover that.
I haven't had a chance to get back to working on any more updates here since I'm still working on updating and migrating some of our other abstractions to dove norms. At some point I was hoping to spend time fixing up the test suite, but it returning results was good enough starter for us for now. Just wanted to post a quick branch for others who may be experimenting with dove.
I should also mention that all my testing was with an elastic search db at version 8.4.3 (hosted on elastic.co) and "@elastic/elasticsearch": "^8.5.0"