feast icon indicating copy to clipboard operation
feast copied to clipboard

chore: Update online store docstrings

Open felixwang9817 opened this issue 3 years ago • 2 comments

Signed-off-by: Felix Wang [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

felixwang9817 avatar Aug 10 '22 22:08 felixwang9817

Codecov Report

Merging #3066 (ceb1432) into master (41851be) will increase coverage by 8.67%. The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #3066      +/-   ##
==========================================
+ Coverage   67.20%   75.87%   +8.67%     
==========================================
  Files         168      203      +35     
  Lines       15011    16983    +1972     
==========================================
+ Hits        10088    12886    +2798     
+ Misses       4923     4097     -826     
Flag Coverage Δ
integrationtests 66.92% <33.33%> (-0.28%) :arrow_down:
unittests 58.23% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/online_stores/dynamodb.py 89.78% <ø> (+10.32%) :arrow_up:
...k/python/feast/infra/online_stores/online_store.py 80.00% <0.00%> (ø)
sdk/python/feast/infra/online_stores/redis.py 95.06% <ø> (ø)
sdk/python/feast/infra/online_stores/sqlite.py 94.48% <ø> (+10.23%) :arrow_up:
sdk/python/feast/infra/online_stores/datastore.py 88.12% <100.00%> (+8.03%) :arrow_up:
sdk/python/feast/cli.py 39.11% <0.00%> (-2.48%) :arrow_down:
setup.py 0.00% <0.00%> (ø)
.../online_stores/contrib/hbase_repo_configuration.py 100.00% <0.00%> (ø)
...k/python/feast/infra/materialization/lambda/app.py 26.66% <0.00%> (ø)
...tores/contrib/trino_offline_store/trino_queries.py 15.05% <0.00%> (ø)
... and 107 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 10 '22 22:08 codecov-commenter

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [achals,adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

feast-ci-bot avatar Aug 15 '22 14:08 feast-ci-bot

/lgtm

kevjumba avatar Aug 22 '22 22:08 kevjumba