feast
feast copied to clipboard
feat: Add Snowflake materialization engine
What this PR does / why we need it:
Allows Snowflake to be a materialization option when Snowflake is used as an offline store
Which issue(s) this PR fixes:
Fixes #
Codecov Report
Merging #2948 (5d0cf95) into master (83c5efb) will decrease coverage by
9.28%. The diff coverage is33.42%.
@@ Coverage Diff @@
## master #2948 +/- ##
==========================================
- Coverage 67.08% 57.80% -9.29%
==========================================
Files 173 209 +36
Lines 15132 17380 +2248
==========================================
- Hits 10152 10046 -106
- Misses 4980 7334 +2354
| Flag | Coverage Δ | |
|---|---|---|
| integrationtests | ? |
|
| unittests | 57.80% <33.42%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...hon/feast/infra/offline_stores/snowflake_source.py | 63.04% <14.70%> (-29.27%) |
:arrow_down: |
| ...hon/feast/infra/utils/snowflake/snowflake_utils.py | 18.96% <20.51%> (ø) |
|
| ...on/feast/infra/materialization/snowflake_engine.py | 34.37% <34.37%> (ø) |
|
| ...ests/integration/materialization/test_snowflake.py | 38.09% <38.09%> (ø) |
|
| sdk/python/feast/infra/offline_stores/snowflake.py | 37.19% <46.15%> (-47.14%) |
:arrow_down: |
| sdk/python/feast/type_map.py | 46.54% <46.66%> (-13.75%) |
:arrow_down: |
| ...python/feast/infra/offline_stores/offline_store.py | 67.64% <50.00%> (-15.36%) |
:arrow_down: |
| sdk/python/feast/repo_config.py | 76.62% <50.00%> (-6.77%) |
:arrow_down: |
| sdk/python/feast/infra/online_stores/snowflake.py | 47.66% <71.42%> (-50.51%) |
:arrow_down: |
| .../feature_repos/universal/data_sources/snowflake.py | 51.21% <100.00%> (-48.79%) |
:arrow_down: |
| ... and 165 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@sfc-gh-madkins could you fix dco?
Tests are red because of a couple of tests that aren't being skipped correctly (since pr-local-integration-tests is triggered on pull_request_target).
Going to force merge this in.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: achals, kevjumba, sfc-gh-madkins
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [achals,kevjumba]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment