feast icon indicating copy to clipboard operation
feast copied to clipboard

feat: Add support for fetching features using multiple feature views with different entities in the Java feature server

Open vstrimaitis opened this issue 3 years ago • 6 comments

What this PR does / why we need it: When fetching features from multiple features views using different entities, the feature server returns NOT_FOUND for all of the features instead of properly using the available information to get all feature values. This PR fixes this issue.

Which issue(s) this PR fixes:

Fixes #2302

Does this PR introduce a user-facing change?:

Java feature server supports fetching from multiple feature views with different entities

vstrimaitis avatar Feb 17 '22 11:02 vstrimaitis

Codecov Report

Merging #2316 (09ef3d1) into master (c2a6c6c) will decrease coverage by 3.12%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2316      +/-   ##
==========================================
- Coverage   86.54%   83.42%   -3.13%     
==========================================
  Files         117      122       +5     
  Lines        9753    10704     +951     
==========================================
+ Hits         8441     8930     +489     
- Misses       1312     1774     +462     
Flag Coverage Δ
integrationtests 73.16% <ø> (-2.59%) :arrow_down:
unittests 57.12% <ø> (-1.34%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/wait.py 58.82% <0.00%> (-35.30%) :arrow_down:
.../integration/online_store/test_universal_online.py 70.82% <0.00%> (-26.61%) :arrow_down:
sdk/python/tests/conftest.py 78.87% <0.00%> (-12.97%) :arrow_down:
sdk/python/feast/registry.py 83.12% <0.00%> (-2.88%) :arrow_down:
sdk/python/feast/type_map.py 67.42% <0.00%> (-1.09%) :arrow_down:
sdk/python/feast/feature_store.py 90.83% <0.00%> (-1.07%) :arrow_down:
sdk/python/feast/inference.py 83.82% <0.00%> (-1.03%) :arrow_down:
...thon/feast/infra/offline_stores/bigquery_source.py 86.20% <0.00%> (-0.93%) :arrow_down:
sdk/python/feast/saved_dataset.py 81.66% <0.00%> (-0.79%) :arrow_down:
sdk/python/feast/diff/registry_diff.py 69.46% <0.00%> (-0.79%) :arrow_down:
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c2a6c6c...09ef3d1. Read the comment docs.

codecov-commenter avatar Feb 17 '22 18:02 codecov-commenter

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, vstrimaitis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

feast-ci-bot avatar Feb 25 '22 23:02 feast-ci-bot

mind rebasing against master? think the tests should be fixed

adchia avatar Feb 28 '22 19:02 adchia

Hey @vstrimaitis are you still working on this PR? The PR is very close barring a few small cleanup changes!

kevjumba avatar Mar 21 '22 17:03 kevjumba

Hey @vstrimaitis are you still working on this PR? The PR is very close barring a few small cleanup changes!

I have most of the suggestions implemented, but I'm still missing the last few. I'm a bit preoccupied at the moment to finish this up, so if someone wants to help with that - feel free to do it! Otherwise, I'll try to get back to this whenever I have some spare time.

vstrimaitis avatar Mar 22 '22 09:03 vstrimaitis

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 20 '22 18:09 stale[bot]