next_rails icon indicating copy to clipboard operation
next_rails copied to clipboard

[FEATURE] Add bundle_report compatibility --ruby-version report

Open JuanVqz opened this issue 1 year ago • 2 comments

Description

Closes https://github.com/fastruby/next_rails/issues/115 Closes https://github.com/fastruby/next_rails/issues/17

Motivation and Context

Have an easy way to get the incompatible gems with a given ruby version.

How Has This Been Tested?

Wrote some automated tests and Installed the gem locally

Screenshots:

Peek 2024-05-19 22-48

I will abide by the code of conduct

JuanVqz avatar May 18 '24 22:05 JuanVqz

I tested and It looks good! Added just minor comments 🚀 !!

Also, not for this PR, but now that you added lib/next_rails/bundle_report/ruby_version_compatibility.rb maybe worth moving rails logic to lib/next_rails/bundle_report/rails_version_compatibility.rb and have a kind of "strategy pattern" or something similar at #compatibility that call one or other.

Yeah! that's a great suggestion, looking forward to doing it next...

p.s.: Remember to increase the version.

Not for this PR, we can bump the version o a specific PR

JuanVqz avatar Jul 31 '24 19:07 JuanVqz

@etagwerker or @rishijain can you please merge this PR? Julio already tested it :shipit: Thanks!

JuanVqz avatar Jul 31 '24 19:07 JuanVqz