next_rails
next_rails copied to clipboard
[FEATURE] Add bundle_report compatibility --ruby-version report
Description
Closes https://github.com/fastruby/next_rails/issues/115 Closes https://github.com/fastruby/next_rails/issues/17
Motivation and Context
Have an easy way to get the incompatible gems with a given ruby version.
How Has This Been Tested?
Wrote some automated tests and Installed the gem locally
Screenshots:
I will abide by the code of conduct
I tested and It looks good! Added just minor comments 🚀 !!
Also, not for this PR, but now that you added
lib/next_rails/bundle_report/ruby_version_compatibility.rbmaybe worth moving rails logic to lib/next_rails/bundle_report/rails_version_compatibility.rb and have a kind of "strategy pattern" or something similar at#compatibilitythat call one or other.
Yeah! that's a great suggestion, looking forward to doing it next...
p.s.: Remember to increase the version.
Not for this PR, we can bump the version o a specific PR
@etagwerker or @rishijain can you please merge this PR? Julio already tested it :shipit: Thanks!