light-my-request icon indicating copy to clipboard operation
light-my-request copied to clipboard

migrate to class

Open sirenkovladd opened this issue 2 years ago • 3 comments

migrate to class syntax (Chain, request, response)

copied class from https://github.com/fastify/light-my-request/pull/252 but without changing the logic in lib/do-inject.js (doInject) (to resolve Test Fastify Integration)

Checklist

sirenkovladd avatar Oct 28 '23 04:10 sirenkovladd

@jsumners, Can you explain your negative attitude?

sirenkovladd avatar Oct 30 '23 15:10 sirenkovladd

  • https://github.com/fastify/light-my-request/pull/252#issuecomment-1700289217
  • https://github.com/fastify/light-my-request/pull/252#issuecomment-1700941877
  • https://github.com/fastify/light-my-request/pull/252#issuecomment-1701062425
  • https://github.com/fastify/light-my-request/pull/252#issuecomment-1781074509

jsumners avatar Oct 30 '23 16:10 jsumners

@jsumners I'm not mentioning bun in this PR (since not all issues are resolved) what happens in this PR is the grouping of the function into a class (it was already there, but it was Function.constructor I go to the class syntax) on the contrary, it will be easier to maintain

sirenkovladd avatar Oct 30 '23 16:10 sirenkovladd