fastify-mongodb icon indicating copy to clipboard operation
fastify-mongodb copied to clipboard

Update for Fastify v5

Open synapse opened this issue 1 year ago • 2 comments
trafficstars

Ref: https://github.com/fastify/fastify/issues/5116

  • this PR replaces the embedded custom plugin in favor of 3 functions (maintaining the same structure inside) (tap 18 requires its plugins to be loaded from node_modules)
  • considering the above change, I've replaced the plugin with subtests (that do not need a repetitive title) which will run the assertion function just as before

⚠️ ~~Not sure about the version of CI used for this repo. Currently is set to:~~

fastify/workflows/.github/workflows/plugins-ci-mongo.yml@7993e1ea858b5c3ceff1aa154fa44b892f311ac3

☝️ used version v4.1.0

~~Can anyone confirm that there's a newer version for deploying for this repo?~~

Checklist

CC @simoneb

synapse avatar Mar 20 '24 09:03 synapse

Not sure about the version of CI used for this repo.

Based on the diff, I'd say you can go to the same tag as the other repos

simoneb avatar Mar 20 '24 11:03 simoneb

it may be worth considering to do also #226 since it's a major. next branch created and rebased meanwhile

simoneb avatar Mar 20 '24 11:03 simoneb

FYI, the workflows hash uses because mongodb@6 is dropped node@14 supports earlier than fastify@5 exists. So, this plugin need to be dropping the support earlier than other plugin.

climba03003 avatar Apr 01 '24 07:04 climba03003

FYI, the workflows hash uses because mongodb@6 is dropped node@14 supports earlier than fastify@5 exists. So, this plugin need to be dropping the support earlier than other plugin.

Hey @climba03003, I'm not sure if you've meant to keep the original hash or is it ok to move forward with the current v4.1.0 tag?

synapse avatar Apr 02 '24 09:04 synapse

It just the background of why the hash exist, I am good with v4.1.0

climba03003 avatar Apr 02 '24 09:04 climba03003