fastify-mongodb
fastify-mongodb copied to clipboard
Update for Fastify v5
Ref: https://github.com/fastify/fastify/issues/5116
- this PR replaces the embedded custom plugin in favor of 3 functions (maintaining the same structure inside) (tap 18 requires its plugins to be loaded from
node_modules) - considering the above change, I've replaced the plugin with subtests (that do not need a repetitive title) which will run the assertion function just as before
⚠️ ~~Not sure about the version of CI used for this repo. Currently is set to:~~
fastify/workflows/.github/workflows/plugins-ci-mongo.yml@7993e1ea858b5c3ceff1aa154fa44b892f311ac3
☝️ used version v4.1.0
~~Can anyone confirm that there's a newer version for deploying for this repo?~~
Checklist
- [x] run
npm run testandnpm run benchmark - [x] tests and/or benchmarks are included
- [ ] documentation is changed or added
- [x] commit message and code follows the Developer's Certification of Origin and the Code of conduct
CC @simoneb
Not sure about the version of CI used for this repo.
Based on the diff, I'd say you can go to the same tag as the other repos
it may be worth considering to do also #226 since it's a major. next branch created and rebased meanwhile
FYI, the workflows hash uses because mongodb@6 is dropped node@14 supports earlier than fastify@5 exists.
So, this plugin need to be dropping the support earlier than other plugin.
FYI, the workflows hash uses because
mongodb@6is droppednode@14supports earlier thanfastify@5exists. So, this plugin need to be dropping the support earlier than other plugin.
Hey @climba03003, I'm not sure if you've meant to keep the original hash or is it ok to move forward with the current v4.1.0 tag?
It just the background of why the hash exist, I am good with v4.1.0