fastify-mongodb
fastify-mongodb copied to clipboard
chore: move mongodb to devDeps and add it to peerDeps
Checklist
- [ ] run
npm run testandnpm run benchmark - [ ] tests and/or benchmarks are included
- [ ] documentation is changed or added
- [x] commit message and code follows the Developer's Certification of Origin and the Code of conduct
The default value of omit option is dev.
From npm version >= 7 (Node version >= 16) peer dependencies are autoinstalled: source.
Imply that mongodb, as peer dependency, will be installed with omit=dev.
Unfortunately the minimum supported version of this module is Node v14.
Generically we prefer to stay away from peerdependencies because they create more problems than what they are worth.
Unfortunately the minimum supported version of this module is Node v14.
For mongodb v6 the minimum supported Node.js version is v16.20.1 (source).
Oof, that's correct, good catch
A PR that downgrades it is welcome
I would really prefer avoiding peerDependencies anyway. They are just a source of headaches for maintainers.
Node v14 isn't mantained, when it will be removed?
When Fastify v5 is released (probably by the end of this year)
I am closing the PR because we avoid using peerDependencies in any case. So, it is not going to merge in anytime.