fastfetch icon indicating copy to clipboard operation
fastfetch copied to clipboard

[FEAT] Improve detection for images when running in sudo or ssh

Open Thelvaen opened this issue 1 year ago • 8 comments
trafficstars

Wanted features:

When accessing a computer through ssh or changing user through sudo, png logos are not displayed properly.

Motivation:

having the fallback to the ASCII version of the logo would be nicer than just having PNG written at the top of the output.

Thelvaen avatar May 02 '24 11:05 Thelvaen

So, like a PNG turns into ASCII art as a fallback?

1ivyatan avatar May 02 '24 12:05 1ivyatan

probably easier to understand what I mean through screenshots. in sudo image in ssh image I'd rather have something like that: image

Thelvaen avatar May 02 '24 12:05 Thelvaen

The escape code may need to be wrapped. Will investigate it later

CarterLi avatar May 02 '24 12:05 CarterLi

Does neofetch work in this case?

CarterLi avatar May 02 '24 12:05 CarterLi

when using sudo it works, when ran through SSH it does not show the image, but properly fallback to the ascii art version of the logo.

Thelvaen avatar May 02 '24 12:05 Thelvaen

Should be fixed in https://github.com/fastfetch-cli/fastfetch/commit/71cba2451a13fdb56bbbdca943a3fb8fd194d901

CarterLi avatar May 03 '24 02:05 CarterLi

Commit reverted.

Image logos in SSH session do work for me

image

CarterLi avatar May 04 '24 11:05 CarterLi

sudo works too

image

CarterLi avatar May 04 '24 11:05 CarterLi